Issue 7311097: rpc: add support for error codes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311097: rpc: add support for error codes

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 5 months ago

Reviewers:
dimitern, mp+148451, fwereade

Visibility:
Public.

Description

rpc: add support for error codes We need some way of transporting known kinds of error across the link. This seems better than regexp matches on error messages. https://code.launchpad.net/~rogpeppe/juju-core/215-rpc-error-codes/+merge/148451 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: add support for error codes #

Total comments: 2

Patch Set 3 : rpc: add support for error codes #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -2 lines)			Patch
[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
rpc/client.go	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download
rpc/rpc_test.go	View		5 chunks	+40 lines, -1 line	0 comments	Download
rpc/server.go	View		3 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM with one question. https://codereview.appspot.com/7311097/diff/2001/rpc/client.go File rpc/client.go (right): https://codereview.appspot.com/7311097/diff/2001/rpc/client.go#newcode73 rpc/client.go:73: return "server error: " + ...

12 years, 5 months ago (2013-02-14 13:50:15 UTC) #2

rog

https://codereview.appspot.com/7311097/diff/2001/rpc/client.go File rpc/client.go (right): https://codereview.appspot.com/7311097/diff/2001/rpc/client.go#newcode73 rpc/client.go:73: return "server error: " + e.Message On 2013/02/14 13:50:15, ...

12 years, 5 months ago (2013-02-14 14:15:53 UTC) #3

fwereade

LGTM, assuming we get a followup implementing the NotFound stuff imminently :).

12 years, 5 months ago (2013-02-14 14:27:11 UTC) #4

rog

12 years, 5 months ago (2013-02-14 16:18:10 UTC) #5

*** Submitted:

rpc: add support for error codes

We need some way of transporting known
kinds of error across the link.
This seems better than regexp matches
on error messages.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7311097

Expand All Messages | Collapse All Messages