Issue 7311096: Fix tests that rely on the ordering of values in a dictionary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311096: Fix tests that rely on the ordering of values in a dictionary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by jcgregorio_google

Modified:
11 years, 2 months ago

Reviewers:
dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Fix tests that rely on the ordering of values in a dictionary. Also update upload-diffs.py to the latest version.

Patch Set 1 #

Total comments: 3

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+430 lines, -241 lines)			Patch
M	tests/test_discovery.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/test_push.py	View	3 chunks	+13 lines, -8 lines	0 comments	Download
M	upload-diffs.py	View	60 chunks	+416 lines, -232 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/7311096/diff/1/tests/test_discovery.py File tests/test_discovery.py (right): https://codereview.appspot.com/7311096/diff/1/tests/test_discovery.py#newcode866 tests/test_discovery.py:866: self.assertEqual(sorted(zoo._dynamic_attrs), sorted(new_zoo._dynamic_attrs)) Good catch. Though _dynamic_attrs is a ...

11 years, 2 months ago (2013-02-13 19:36:25 UTC) #2

jcgregorio_google

11 years, 2 months ago (2013-02-13 20:44:25 UTC) #3

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=eabdb31907...

https://codereview.appspot.com/7311096/diff/1/upload-diffs.py
File upload-diffs.py (right):

https://codereview.appspot.com/7311096/diff/1/upload-diffs.py#newcode2
upload-diffs.py:2: # coding: utf-8
No, I haven't bothered to date given how simple the changes are and how
infrequently I update the script, but I'm not opposed to doing so.

On 2013/02/13 19:36:25, dhermes wrote:
> I downloaded this patch, applied at and then download
> https://codereview.appspot.com/static/upload.py to do a diff.
> 
> Once I saw the actual changes, it was simple. Is there some automated script
you
> use to change the reviewers and cc lines?

Expand All Messages | Collapse All Messages