Issue 7311085: code review 7311085: runtime: move stack management related code to stack.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311085: code review 7311085: runtime: move stack management related code to stack.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dvyukov

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, minux1, rsc

Visibility:
Public.

Description

runtime: move stack management related code to stack.c No code changes. This is mainly in preparation to scheduler changes, oldstack/newstack are not related to scheduling.

Patch Set 1 #

Patch Set 2 : diff -r d89c5a625fb5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d89c5a625fb5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d89c5a625fb5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r a394d9eeb49a https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -275 lines)			Patch
M	src/pkg/runtime/malloc.goc	View	1	2 chunks	+0 lines, -119 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	2 chunks	+0 lines, -156 lines	0 comments	Download
A	src/pkg/runtime/stack.c	View	1	1 chunk	+279 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

13 years, 8 months ago (2013-02-12 16:26:16 UTC) #1

dvyukov

13 years, 8 months ago (2013-02-14 08:39:42 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=56a67e91377c ***

runtime: move stack management related code to stack.c
No code changes.
This is mainly in preparation to scheduler changes,
oldstack/newstack are not related to scheduling.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/7311085

Expand All Messages | Collapse All Messages