Install as webops_deploy, run as charmworld

Install as webops_deploy, run as charmworld

Update hooks to install files as webops_deploy, but to run charmworld as the
charmworld user.  Log files and branches are written to ~charmworld/var.
nginx is updated to use the new location for static files.

https://code.launchpad.net/~abentley/charms/precise/charmworld/special-users/+merge/147228

(do not edit description out of merge proposal)

[abentley-home, 2013-02-07 21:16:30]

Please take a look.

[rharding, 2013-02-07 21:40:55]

lgtm just wanted to check on using the new common variables in more places to
prevent too many occurances to change later if needed.

https://codereview.appspot.com/7311060/diff/1/files/nrpe-external-master/chec...
File files/nrpe-external-master/check_ingest.sh (right):

https://codereview.appspot.com/7311060/diff/1/files/nrpe-external-master/chec...
files/nrpe-external-master/check_ingest.sh:2: if [ -f
/home/charmworld/var/ingest-errors ]; then
Should this be set to use the charmworld_home var defined in common?

https://codereview.appspot.com/7311060/diff/1/hooks/config-changed
File hooks/config-changed (right):

https://codereview.appspot.com/7311060/diff/1/hooks/config-changed#newcode82
hooks/config-changed:82: */$interval * * * * charmworld HOME=/home/charmworld
LOGDIR=$log_dir INI=$CONFIG_FILE ~webops_deploy/run-write-errors
$log_dir/ingest-errors $project_dir/scripts/ingest
again should this use the variable defined for charmworkd_home like the log_dir
variable?

https://codereview.appspot.com/7311060/diff/1/hooks/config-changed#newcode83
hooks/config-changed:83: @daily charmworld HOME=/home/webops_deploy
INI=$project_dir/production.ini $project_dir/bin/python
$project_dir/charmworld/jobs/cstat.py
and webops_home here.

[curtis, 2013-02-07 21:42:14]

Thank you Aaron, lgtm.

I don't have any comment about the mechanical changes in in the diff. I was
surprised to see the "-R" option following the positional args to chown in a few
places (they pre-exist your change). I was surprised. I used to reading the
options before what might be a long of positional args.

[abentley-home, 2013-02-07 21:45:46]

On 2013/02/07 21:40:55, rharding wrote:
>
https://codereview.appspot.com/7311060/diff/1/files/nrpe-external-master/chec...
> files/nrpe-external-master/check_ingest.sh:2: if [ -f
> /home/charmworld/var/ingest-errors ]; then
> Should this be set to use the charmworld_home var defined in common?

No, because this is a standalone script, not a hook.  It winds up getting
installed in /etc, IIRC.

> https://codereview.appspot.com/7311060/diff/1/hooks/config-changed#newcode82
> hooks/config-changed:82: */$interval * * * * charmworld HOME=/home/charmworld
> LOGDIR=$log_dir INI=$CONFIG_FILE ~webops_deploy/run-write-errors
> $log_dir/ingest-errors $project_dir/scripts/ingest
> again should this use the variable defined for charmworkd_home like the
log_dir
> variable?

Sure.

> https://codereview.appspot.com/7311060/diff/1/hooks/config-changed#newcode83
> hooks/config-changed:83: @daily charmworld HOME=/home/webops_deploy
> INI=$project_dir/production.ini $project_dir/bin/python
> $project_dir/charmworld/jobs/cstat.py
> and webops_home here.

Sure.