Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3865)

Issue 7311046: Trivial - name magic numbers

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by matthew.scott
Modified:
11 years, 2 months ago
Reviewers:
mp+146650, bcsaller
Visibility:
Public.

Description

Trivial - name magic numbers https://code.launchpad.net/~makyo/juju-gui/trivials/+merge/146650 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Trivial - name magic numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/relation.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/views/topology/service.js View 2 chunks +3 lines, -3 lines 0 comments Download
M app/views/topology/topology.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
matthew.scott
Please take a look.
11 years, 2 months ago (2013-02-05 15:29:59 UTC) #1
bcsaller
+1 LGTM
11 years, 2 months ago (2013-02-05 15:33:28 UTC) #2
matthew.scott
11 years, 2 months ago (2013-02-05 15:49:21 UTC) #3
*** Submitted:

Trivial - name magic numbers

R=bcsaller
CC=
https://codereview.appspot.com/7311046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b