Issue 7310095: state/api: use reliable test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7310095: state/api: use reliable test

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
mp+148722, dimitern, dfc

Visibility:
Public.

Description

state/api: use reliable test When we Stop the server, the client does not get immediate notification, so we can't guarantee an immediate ErrShutdown response. Also make errors more consistent in rpc. https://code.launchpad.net/~rogpeppe/juju-core/218-api-either-error/+merge/148722 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: use reliable test #

Total comments: 2

Patch Set 3 : state/api: use reliable test #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/client.go	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	rpc/rpc_test.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/api/api_test.go	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM https://codereview.appspot.com/7310095/diff/2001/rpc/client.go File rpc/client.go (right): https://codereview.appspot.com/7310095/diff/2001/rpc/client.go#newcode187 rpc/client.go:187: err = ErrShutdown So the client will definitely ...

11 years, 2 months ago (2013-02-15 14:22:56 UTC) #2

rog

https://codereview.appspot.com/7310095/diff/2001/rpc/client.go File rpc/client.go (right): https://codereview.appspot.com/7310095/diff/2001/rpc/client.go#newcode187 rpc/client.go:187: err = ErrShutdown On 2013/02/15 14:22:56, dimitern wrote: > ...

11 years, 2 months ago (2013-02-15 14:26:20 UTC) #3

rog

11 years, 2 months ago (2013-02-18 12:06:21 UTC) #5

*** Submitted:

state/api: use reliable test

When we Stop the server, the client does
not get immediate notification, so we can't
guarantee an immediate ErrShutdown response.

Also make errors more consistent in rpc.

R=dimitern, dfc
CC=
https://codereview.appspot.com/7310095

Expand All Messages | Collapse All Messages