Issue 7310068: code review 7310068: net: fix unixgram

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7310068: code review 7310068: net: fix unixgram (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by mikio

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: fix unixgram The socket for AF_UNIX domain with SOCK_DGARM type isn't allowed to work with syscall listen.

Patch Set 2 : diff -r 7cb3730e3f37 https://code.google.com/p/go #

Patch Set 3 : diff -r 7cb3730e3f37 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 6094e6f45477 https://code.google.com/p/go #

Patch Set 5 : diff -r 4730daf6696c https://code.google.com/p/go #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	src/pkg/net/dial.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/net/unixsock_plan9.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/net/unixsock_posix.go	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 4 months ago (2013-02-08 16:09:32 UTC) #1

rsc

https://codereview.appspot.com/7310068/diff/2002/src/pkg/net/unixsock_posix.go File src/pkg/net/unixsock_posix.go (right): https://codereview.appspot.com/7310068/diff/2002/src/pkg/net/unixsock_posix.go#newcode254 src/pkg/net/unixsock_posix.go:254: // Unix listener. The network net must be "unix" ...

12 years, 4 months ago (2013-02-08 16:18:45 UTC) #2

mikio

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 4 months ago (2013-02-08 16:39:58 UTC) #3

mikio

12 years, 4 months ago (2013-02-08 16:40:02 UTC) #4

mikio

12 years, 4 months ago (2013-02-08 23:18:43 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=6e2799b3847b ***

net: fix unixgram

The socket for AF_UNIX domain with SOCK_DGARM type isn't
allowed to work with syscall listen.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7310068

Expand All Messages | Collapse All Messages