Issue 7310051: code review 7310051: crypto/rc4: naïve ARM assembly implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7310051: code review 7310051: crypto/rc4: naïve ARM assembly implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by minux1

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, agl1, dave_cheney.net

Visibility:
Public.

Description

crypto/rc4: naïve ARM assembly implementation On 800MHz Cortex-A8: benchmark old ns/op new ns/op delta BenchmarkRC4_128 9395 2838 -69.79% BenchmarkRC4_1K 74497 22120 -70.31% BenchmarkRC4_8K 587243 171435 -70.81% benchmark old MB/s new MB/s speedup BenchmarkRC4_128 13.62 45.09 3.31x BenchmarkRC4_1K 13.75 46.29 3.37x BenchmarkRC4_8K 13.79 47.22 3.42x Result for "OpenSSL 1.0.1c 10 May 2012" from Debian/armhf sid: type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes rc4 39553.81k 46522.39k 49336.11k 50085.63k 50258.06k

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -2 lines)			Patch
A	src/pkg/crypto/rc4/rc4_arm.s	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/rc4/rc4_asm.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/rc4/rc4_ref.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 5 months ago (2013-02-06 19:13:16 UTC) #1

dave_cheney.net

Very nice. Thank you On Thu, Feb 7, 2013 at 8:08 AM, <agl@golang.org> wrote: > ...

12 years, 5 months ago (2013-02-06 21:34:02 UTC) #3

minux1

12 years, 5 months ago (2013-02-07 10:54:36 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=aba17f1b93db ***

crypto/rc4: naïve ARM assembly implementation

On 800MHz Cortex-A8:
benchmark           old ns/op    new ns/op    delta
BenchmarkRC4_128         9395         2838  -69.79%
BenchmarkRC4_1K         74497        22120  -70.31%
BenchmarkRC4_8K        587243       171435  -70.81%

benchmark            old MB/s     new MB/s  speedup
BenchmarkRC4_128        13.62        45.09    3.31x
BenchmarkRC4_1K         13.75        46.29    3.37x
BenchmarkRC4_8K         13.79        47.22    3.42x

Result for "OpenSSL 1.0.1c 10 May 2012" from Debian/armhf sid:
type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes
rc4              39553.81k    46522.39k    49336.11k    50085.63k    50258.06k

R=golang-dev, agl, dave
CC=golang-dev
https://codereview.appspot.com/7310051

Expand All Messages | Collapse All Messages