code review 73100043: syscall: add missing SO_ERROR constant for nacl/*

syscall: add missing SO_ERROR constant for nacl/*

CL 69340044 requires that syscall.SO_ERROR be defined on all unix like platforms. Add SO_ERROR to the list of dummy constants in sycall/net_nacl.go.

[dave_cheney.net, 2014-03-09 02:01:17]

Hello iant@golang.org, rsc@golang.org, mikioh.mikioh@gmail.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-09 02:02:23]

LGTM
 On Mar 8, 2014 6:01 PM, <dave@cheney.net> wrote:

> Reviewers: iant, rsc, mikio,
>
> Message:
> Hello iant@golang.org, rsc@golang.org, mikioh.mikioh@gmail.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: add missing SO_ERROR constant for nacl/*
>
> CL 69340044 requires that syscall.SO_ERROR be defined on all unix like
> platforms. Add SO_ERROR to the list of dummy constants in
> sycall/net_nacl.go.
>
> Please review this at https://codereview.appspot.com/73100043/
>
> Affected files (+1, -0 lines):
>   M src/pkg/syscall/net_nacl.go
>
>
> Index: src/pkg/syscall/net_nacl.go
> ===================================================================
> --- a/src/pkg/syscall/net_nacl.go
> +++ b/src/pkg/syscall/net_nacl.go
> @@ -112,6 +112,7 @@
>         SO_SNDBUF
>         SO_KEEPALIVE
>         SO_LINGER
> +       SO_ERROR
>         IP_MULTICAST_IF
>         IP_MULTICAST_LOOP
>         IP_ADD_MEMBERSHIP
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dave_cheney.net, 2014-03-09 02:18:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=1849f83423ca ***

syscall: add missing SO_ERROR constant for nacl/*

CL 69340044 requires that syscall.SO_ERROR be defined on all unix like
platforms. Add SO_ERROR to the list of dummy constants in sycall/net_nacl.go.

LGTM=bradfitz
R=iant, rsc, mikioh.mikioh, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/73100043

[gobot, 2014-03-09 02:22:36]

This CL appears to have broken the freebsd-amd64 builder.

[dave_cheney.net, 2014-03-09 02:25:08]

Lies!

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestFutexsleep-2 (0.00 seconds)
futex_test.go:51: futexsleep test "before the year 2038" finished
early after 34.64us
FAIL
FAIL runtime 58.566s

On Sun, Mar 9, 2014 at 1:22 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64 builder.
>
> https://codereview.appspot.com/73100043/