code review 7308067: cmd/hgpatch: rename to cmd/hgapplydiff

cmd/hgpatch: rename to cmd/hgapplydiff

This avoids problems executing the binary on Windows.
Windows rejects exe files whose name contains 'install' or 'patch'
in a misguided attempt to detect software installers.

[rsc, 2013-02-08 03:32:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.codereview

[dave_cheney.net, 2013-02-08 03:39:19]

This is why we cannot have nice things.

On Fri, Feb 8, 2013 at 2:32 PM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.codereview
>
>
> Description:
> cmd/hgpatch: rename to cmd/hgapplydiff
>
> This avoids problems executing the binary on Windows.
> Windows rejects exe files whose name contains 'install' or 'patch'
> in a misguided attempt to detect software installers.
>
> Please review this at https://codereview.appspot.com/7308067/
>
> Affected files:
>   M cmd/hgapplydiff/doc.go
>   M cmd/hgapplydiff/main.go
>
>
> Index: cmd/hgapplydiff/doc.go
> ===================================================================
> rename from cmd/hgpatch/doc.go
> rename to cmd/hgapplydiff/doc.go
> --- a/cmd/hgpatch/doc.go
> +++ b/cmd/hgapplydiff/doc.go
> @@ -4,15 +4,17 @@
>
>  /*
>
> -Hgpatch applies a patch to the local Mercurial repository.
> +Hgapplydiff applies a patch to the local Mercurial repository.
>  The patch should have been been generated by
>  a version control system like CVS, Git, Mercurial, or Subversion.
> -If successful, hgpatch writes a list of affected files to standard output.
> +If successful, hgapplydiff writes a list of affected files to standard
> output.
>
> -Hgpatch is meant to be used by the Mercurial codereview extension.
> +Hgapplydiff is meant to be used by the Mercurial codereview extension.
> +It was formerly named hgpatch, but executables containing the name
> +patch cause problems on Windows.
>
>  Usage:
> -       hgpatch [patchfile]
> +       hgapplydiff [patchfile]
>
>  */
>  package documentation
> Index: cmd/hgapplydiff/main.go
> ===================================================================
> rename from cmd/hgpatch/main.go
> rename to cmd/hgapplydiff/main.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[bradfitz, 2013-02-08 03:41:37]

LGTM hahah

On Thu, Feb 7, 2013 at 7:32 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://code.google.com/p/go.**codereview<https://code.google.com/p/go.codere...
>
>
> Description:
> cmd/hgpatch: rename to cmd/hgapplydiff
>
> This avoids problems executing the binary on Windows.
> Windows rejects exe files whose name contains 'install' or 'patch'
> in a misguided attempt to detect software installers.
>
> Please review this at
https://codereview.appspot.**com/7308067/<https://codereview.appspot.com/7308...
>
> Affected files:
>   M cmd/hgapplydiff/doc.go
>   M cmd/hgapplydiff/main.go
>
>
> Index: cmd/hgapplydiff/doc.go
> ==============================**==============================**=======
> rename from cmd/hgpatch/doc.go
> rename to cmd/hgapplydiff/doc.go
> --- a/cmd/hgpatch/doc.go
> +++ b/cmd/hgapplydiff/doc.go
> @@ -4,15 +4,17 @@
>
>  /*
>
> -Hgpatch applies a patch to the local Mercurial repository.
> +Hgapplydiff applies a patch to the local Mercurial repository.
>  The patch should have been been generated by
>  a version control system like CVS, Git, Mercurial, or Subversion.
> -If successful, hgpatch writes a list of affected files to standard output.
> +If successful, hgapplydiff writes a list of affected files to standard
> output.
>
> -Hgpatch is meant to be used by the Mercurial codereview extension.
> +Hgapplydiff is meant to be used by the Mercurial codereview extension.
> +It was formerly named hgpatch, but executables containing the name
> +patch cause problems on Windows.
>
>  Usage:
> -       hgpatch [patchfile]
> +       hgapplydiff [patchfile]
>
>  */
>  package documentation
> Index: cmd/hgapplydiff/main.go
> ==============================**==============================**=======
> rename from cmd/hgpatch/main.go
> rename to cmd/hgapplydiff/main.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-02-08 04:12:47]

*** Submitted as
https://code.google.com/p/go/source/detail?r=fcaf98d794af&repo=codereview ***

cmd/hgpatch: rename to cmd/hgapplydiff

This avoids problems executing the binary on Windows.
Windows rejects exe files whose name contains 'install' or 'patch'
in a misguided attempt to detect software installers.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/7308067