code review 7307127: runtime: Support Solaris AMD64 in lfstack.

runtime: Support Solaris AMD64 in lfstack.
The address space layout is similar on SPARC64 and AMD64 when
running Solaris.

[snabb, 2013-02-16 02:05:39]

Hello gofrontend-dev@googlegroups.com (cc: gofrontend-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/gofrontend/

[iant, 2013-02-20 03:48:04]

https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c
File libgo/runtime/lfstack.c (right):

https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c#newc...
libgo/runtime/lfstack.c:20: #if __SIZEOF_POINTER__ == 8 && defined(__sun__)
Don't we want to this for all SPARC systems, even those that are not Solaris? 
E.g., SPARC GNU/Linux?

[snabb, 2013-02-20 04:27:21]

https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c
File libgo/runtime/lfstack.c (right):

https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c#newc...
libgo/runtime/lfstack.c:20: #if __SIZEOF_POINTER__ == 8 && defined(__sun__)
On 2013/02/20 03:48:04, iant wrote:
> Don't we want to this for all SPARC systems, even those that are not Solaris? 
> E.g., SPARC GNU/Linux?

Good question but unfortunately I do not know. I only know that we need this on
Solaris AMD64 architecture. I do not have access to any SPARC machine and my
searches for "netbsd sparc virtual memory layout" and likewise for Linux turned
up nothing.

I was thinking that the virtual memory layout depends more on the OS than the
CPU architecture but of course it can depend on both. I was assuming that the
previous commit that added this #ifdef was made with only Solaris in mind. I
might be mistaken.

Would it be better to change it to the following? Then it does not change any
existing behavior on any other platforms than Solaris AMD64.

#if __SIZEOF_POINTER__ == 8 && (defined(__sparc__) || (defined(__sun__) &&
defined(__amd64__)))

[iant, 2013-02-20 18:31:20]

On Tue, Feb 19, 2013 at 8:27 PM,  <snabb@epipe.com> wrote:
>
> Would it be better to change it to the following? Then it does not
> change any existing behavior on any other platforms than Solaris AMD64.
>
> #if __SIZEOF_POINTER__ == 8 && (defined(__sparc__) || (defined(__sun__)
> && defined(__amd64__)))

I think that is more likely to be correct.

Ian

[snabb, 2013-02-20 19:08:35]

Hello gofrontend-dev@googlegroups.com, iant@golang.org (cc:
gofrontend-dev@googlegroups.com),

Please take another look.

[iant, 2013-02-20 19:39:53]

LGTM

Thanks.

[iant, 2013-02-20 19:41:11]

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=3b1c3cceaf02 ***

runtime: Support Solaris AMD64 in lfstack.
The address space layout is similar on SPARC64 and AMD64 when
running Solaris.

R=gofrontend-dev, iant
CC=gofrontend-dev
https://codereview.appspot.com/7307127

Committer: Ian Lance Taylor <iant@golang.org>