Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 7307127: code review 7307127: runtime: Support Solaris AMD64 in lfstack. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by snabb
Modified:
13 years, 3 months ago
Reviewers:
CC:
gofrontend-dev_googlegroups.com, iant
Visibility:
Public.

Description

runtime: Support Solaris AMD64 in lfstack. The address space layout is similar on SPARC64 and AMD64 when running Solaris.

Patch Set 1 #

Patch Set 2 : diff -r 29b742a2ed37 https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r 29b742a2ed37 https://code.google.com/p/gofrontend/ #

Total comments: 2

Patch Set 4 : diff -r 29b742a2ed37 https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M libgo/runtime/lfstack.c View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7
snabb
Hello gofrontend-dev@googlegroups.com (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend/
13 years, 3 months ago (2013-02-16 02:05:39 UTC) #1
iant
https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c File libgo/runtime/lfstack.c (right): https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c#newcode20 libgo/runtime/lfstack.c:20: #if __SIZEOF_POINTER__ == 8 && defined(__sun__) Don't we want ...
13 years, 3 months ago (2013-02-20 03:48:04 UTC) #2
snabb
https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c File libgo/runtime/lfstack.c (right): https://codereview.appspot.com/7307127/diff/5001/libgo/runtime/lfstack.c#newcode20 libgo/runtime/lfstack.c:20: #if __SIZEOF_POINTER__ == 8 && defined(__sun__) On 2013/02/20 03:48:04, ...
13 years, 3 months ago (2013-02-20 04:27:21 UTC) #3
iant
On Tue, Feb 19, 2013 at 8:27 PM, <snabb@epipe.com> wrote: > > Would it be ...
13 years, 3 months ago (2013-02-20 18:31:20 UTC) #4
snabb
Hello gofrontend-dev@googlegroups.com, iant@golang.org (cc: gofrontend-dev@googlegroups.com), Please take another look.
13 years, 3 months ago (2013-02-20 19:08:35 UTC) #5
iant
LGTM Thanks.
13 years, 3 months ago (2013-02-20 19:39:53 UTC) #6
iant
13 years, 3 months ago (2013-02-20 19:41:11 UTC) #7
*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=3b1c3cceaf02 ***

runtime: Support Solaris AMD64 in lfstack.
The address space layout is similar on SPARC64 and AMD64 when
running Solaris.

R=gofrontend-dev, iant
CC=gofrontend-dev
https://codereview.appspot.com/7307127

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b