Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(834)

Issue 7307109: More burndown list work

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by jacobr
Modified:
9 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-api-app.git@master
Visibility:
Public.

Description

A huge amount of polish and refactoring of the viewer code. Please ignore the .json files. See http://jacobr-latest.dartlang-api.appspot.com/ for an example of the running app. My apologies for the large size of this CL.

Patch Set 1 #

Total comments: 15
Unified diffs Side-by-side diffs Delta from patch set Stats (+2740 lines, -12010 lines) Patch
M .gitignore View 1 chunk +2 lines, -1 line 0 comments Download
A client/data/18233/apidoc.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/args.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.async.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.collection.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.core.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.crypto.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.dom.indexed_db.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.dom.svg.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.dom.web_audio.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.io.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.isolate.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.json.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.math.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.mirrors.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.scalarlist.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.uri.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/dart.utf.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/fixnum.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/intl.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/logging.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/matcher.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/meta.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/mock.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/serialization.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/18233/unittest.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/data/apidoc.json View 1 chunk +1 line, -0 lines 0 comments Download
A client/lib/ast.dart View 1 chunk +1351 lines, -0 lines 0 comments Download
A client/lib/library_loader.dart View 1 chunk +75 lines, -0 lines 0 comments Download
A + client/lib/markdown.dart View 4 chunks +15 lines, -3 lines 2 comments Download
A + client/lib/model.dart View 14 chunks +190 lines, -34 lines 9 comments Download
A + client/lib/resources.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/lib/src/markdown/ast.dart View 3 chunks +17 lines, -14 lines 0 comments Download
A + client/lib/src/markdown/block_parser.dart View 16 chunks +22 lines, -22 lines 0 comments Download
A + client/lib/src/markdown/html_renderer.dart View 5 chunks +6 lines, -7 lines 0 comments Download
A + client/lib/src/markdown/inline_parser.dart View 10 chunks +15 lines, -15 lines 0 comments Download
M client/pubspec.yaml View 1 chunk +4 lines, -0 lines 2 comments Download
A client/test/ast_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A client/test/run.sh View 1 chunk +104 lines, -0 lines 0 comments Download
A client/test/run_all.dart View 1 chunk +93 lines, -0 lines 0 comments Download
D client/web/ast.dart View 1 chunk +0 lines, -704 lines 0 comments Download
A client/web/details.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A client/web/details.html View 1 chunk +30 lines, -0 lines 2 comments Download
M client/web/doc_link.html View 1 chunk +73 lines, -20 lines 0 comments Download
M client/web/element_summary.html View 6 chunks +38 lines, -53 lines 0 comments Download
M client/web/index.html View 7 chunks +127 lines, -58 lines 0 comments Download
A client/web/kind_icon.html View 1 chunk +24 lines, -0 lines 0 comments Download
D client/web/markdown.dart View 1 chunk +0 lines, -115 lines 0 comments Download
D client/web/model.dart View 1 chunk +0 lines, -303 lines 0 comments Download
D client/web/resources.dart View 1 chunk +0 lines, -49 lines 0 comments Download
A client/web/search.dart View 1 chunk +96 lines, -0 lines 0 comments Download
A client/web/search.html View 1 chunk +40 lines, -0 lines 0 comments Download
D client/web/src/markdown/ast.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D client/web/src/markdown/block_parser.dart View 1 chunk +0 lines, -438 lines 0 comments Download
D client/web/src/markdown/html_renderer.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D client/web/src/markdown/inline_parser.dart View 1 chunk +0 lines, -410 lines 0 comments Download
M client/web/static/apidoc-styles.css View 2 chunks +7 lines, -3 lines 0 comments Download
D client/web/static/apidoc_small.json View 1 chunk +0 lines, -9560 lines 0 comments Download
M client/web/static/styles.css View 13 chunks +278 lines, -75 lines 0 comments Download

Messages

Total messages: 8
jacobr
11 years, 2 months ago (2013-02-13 04:53:51 UTC) #1
sigmund
passing by comments... https://codereview.appspot.com/7307109/diff/1/client/pubspec.yaml File client/pubspec.yaml (right): https://codereview.appspot.com/7307109/diff/1/client/pubspec.yaml#newcode14 client/pubspec.yaml:14: widget: any do you need any ...
11 years, 2 months ago (2013-02-13 22:08:35 UTC) #2
jacobr
Fixed. Uploaded new version to the alternate version of the CL with an easier to ...
11 years, 2 months ago (2013-02-14 00:56:23 UTC) #3
John Messerly
hmmm I still only see patch set #1
11 years, 2 months ago (2013-02-14 00:58:42 UTC) #4
sigmund
I think Jacob is referring to this other CL: https://codereview.appspot.com/7301094 the comment below was a ...
11 years, 2 months ago (2013-02-14 01:01:17 UTC) #5
jacobr
https://codereview.appspot.com/7307109/diff/1/client/lib/markdown.dart File client/lib/markdown.dart (right): https://codereview.appspot.com/7307109/diff/1/client/lib/markdown.dart#newcode119 client/lib/markdown.dart:119: List<MarkdownNode> parseInline(String text) => new InlineParser(text, this).parse(); On 2013/02/14 ...
11 years, 2 months ago (2013-02-14 01:12:19 UTC) #6
sigmund
seems I had written some comments here, they might be duplicate with the comments I ...
11 years, 2 months ago (2013-02-14 04:28:45 UTC) #7
jacobr
11 years, 2 months ago (2013-02-14 05:51:44 UTC) #8
https://codereview.appspot.com/7307109/diff/1/client/lib/model.dart
File client/lib/model.dart (right):

https://codereview.appspot.com/7307109/diff/1/client/lib/model.dart#newcode370
client/lib/model.dart:370: /** Score of the search result match. Higher is
better. */
On 2013/02/14 04:28:46, sigmund wrote:
> + empty line before comment

Done.

https://codereview.appspot.com/7307109/diff/1/client/lib/model.dart#newcode441
client/lib/model.dart:441: // TODO(jacobr): this formula is primitive. We should
order by popularity
On 2013/02/14 04:28:46, sigmund wrote:
> long line 

Done.

https://codereview.appspot.com/7307109/diff/1/client/lib/model.dart#newcode444
client/lib/model.dart:444: num score = -name.indexOf(query) -
element.name.length * 0.001;
On 2013/02/14 04:28:46, sigmund wrote:
> some parethesis might help to make the it clear what precedence you want (I
> assume * applies only to the length)?
Done

https://codereview.appspot.com/7307109/diff/1/client/lib/model.dart#newcode455
client/lib/model.dart:455: // TODO(jacobr): ugly way to do this.
On 2013/02/14 04:28:46, sigmund wrote:
> Could you do?
>   return results.take(maxResults).toList();
Done
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b