Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2092)

Issue 7307104: Test different browsers using the same env.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by frankban
Modified:
11 years, 2 months ago
Reviewers:
mp+148017
Visibility:
Public.

Description

Test different browsers using the same env. Re-deploying the charm to run tests in multiple browsers is no longer required. Browsers can be specified as space separated values in the environment variable JUJU_GUI_TEST_BROWSERS. Chrome is the default. Note that currently only chrome tests pass. Other changes: Implemented a clean up function that can be used to restore a pristine Juju environment, and added a test (deploy a charm) demonstrating how to use it. bin/test-charm now exits with an error if one or more tests fail. Improved browser testing documentation. QA: JUJU_GUI_TEST_BROWSERS="chrome firefox ie" \ bin/test-charm lp:juju-gui You should see chrome tests passing, all the others failing (or raising errors), and the charm deployed only once. https://code.launchpad.net/~frankban/juju-gui/bug-1116698-different-browsers/+merge/148017 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Test different browsers using the same env. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -14 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/test-charm View 1 chunk +8 lines, -1 line 0 comments Download
M docs/browser-testing.rst View 4 chunks +35 lines, -5 lines 0 comments Download
M test/browser.py View 4 chunks +35 lines, -4 lines 0 comments Download
M test/test_charm_running.py View 3 chunks +54 lines, -4 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
11 years, 2 months ago (2013-02-12 18:11:51 UTC) #1
gary.poster
Land as is. This rocks! Thanks. Great docs, helpers and tests. Gary
11 years, 2 months ago (2013-02-12 18:36:15 UTC) #2
matthew.scott
Land as is. Thanks for the work! Good stuff.
11 years, 2 months ago (2013-02-12 18:56:43 UTC) #3
gary.poster
On 2013/02/12 18:36:15, gary.poster wrote: > Land as is. This rocks! Thanks. Great docs, helpers ...
11 years, 2 months ago (2013-02-12 19:02:27 UTC) #4
gary.poster
On 2013/02/12 19:02:27, gary.poster wrote: > On 2013/02/12 18:36:15, gary.poster wrote: > > Land as ...
11 years, 2 months ago (2013-02-12 23:19:28 UTC) #5
frankban
On 2013/02/12 23:19:28, gary.poster wrote: > bug 1123562 (firefox) and > http://sauceio.com/index.php/2012/10/announcing-sauce-support-for-windows-8-and-ie-10/ Looking at tests ...
11 years, 2 months ago (2013-02-13 09:17:03 UTC) #6
frankban
11 years, 2 months ago (2013-02-13 09:31:02 UTC) #7
*** Submitted:

Test different browsers using the same env.

Re-deploying the charm to run tests in multiple browsers
is no longer required. Browsers can be specified as space
separated values in the environment variable 
JUJU_GUI_TEST_BROWSERS. Chrome is the default.

Note that currently only chrome tests pass.

Other changes:

Implemented a clean up function that can be used to
restore a pristine Juju environment, and added a 
test (deploy a charm) demonstrating how to use it.

bin/test-charm now exits with an error if one or 
more tests fail.

Improved browser testing documentation.

QA:

JUJU_GUI_TEST_BROWSERS="chrome firefox ie" \
    bin/test-charm lp:juju-gui

You should see chrome tests passing, all the 
others failing (or raising errors), and the charm 
deployed only once.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7307104
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b