Issue 7307090: rpc: allow concurrent calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7307090: rpc: allow concurrent calls

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
mp+147667, fwereade

Visibility:
Public.

Description

rpc: allow concurrent calls The client side comes substantially from the net/rpc package (no point in reinventing the same wheel); the server side is a little simpler, I hope. https://code.launchpad.net/~rogpeppe/juju-core/211-rpc-concurrent-calls/+merge/147667 Requires: https://code.launchpad.net/~rogpeppe/juju-core/176-rpc-spike/+merge/138089 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: allow concurrent calls #

Patch Set 3 : rpc: allow concurrent calls #

Total comments: 5

Patch Set 4 : rpc: allow concurrent calls #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+535 lines, -214 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/client.go	View	1 2	1 chunk	+209 lines, -41 lines	0 comments	Download
M	rpc/rpc_test.go	View	1 2 3	5 chunks	+246 lines, -112 lines	0 comments	Download
M	rpc/server.go	View		7 chunks	+65 lines, -55 lines	0 comments	Download
M	state/api/api_test.go	View	1 2 3	3 chunks	+4 lines, -1 line	0 comments	Download
M	state/api/apiclient.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/client.go	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	state/api/server.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

LGTM, trivials only https://codereview.appspot.com/7307090/diff/3001/rpc/rpc_test.go File rpc/rpc_test.go (right): https://codereview.appspot.com/7307090/diff/3001/rpc/rpc_test.go#newcode163 rpc/rpc_test.go:163: err := <-srvDone sorry, missed this ...

11 years, 2 months ago (2013-02-12 14:08:08 UTC) #3

rog

11 years, 2 months ago (2013-02-12 17:46:32 UTC) #4

*** Submitted:

rpc: allow concurrent calls

The client side comes substantially from
the net/rpc package (no point in reinventing
the same wheel); the server side is a little
simpler, I hope.

R=fwereade
CC=
https://codereview.appspot.com/7307090

Expand All Messages | Collapse All Messages