code review 7307082: spec: reject top-level init names

spec: reject top-level init names

Fixes issue 4586.

[rsc, 2013-02-09 18:52:05]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[remyoudompheng, 2013-02-09 19:09:12]

Is it allowed to
import init "mypkg" ?

2013/2/9, rsc@golang.org <rsc@golang.org>:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> spec: reject top-level init names
>
> Fixes issue 4586.
>
> Please review this at https://codereview.appspot.com/7307082/
>
> Affected files:
>    M doc/go_spec.html
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -5475,6 +5475,9 @@
>   <code>init</code> functions, even
>   within a single source file; they execute
>   in unspecified order.
> +A package must not contain package-level constants
> +or variables named <code>init</code>, nor functions
> +named <code>init</code> without the required signature.
>   </p>
>   <p>
>   Within a package, package-level variables are initialized,
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[rsc, 2013-02-09 19:12:00]

On Sat, Feb 9, 2013 at 2:09 PM, Rémy Oudompheng
<remyoudompheng@gmail.com>wrote:

> Is it allowed to
> import init "mypkg" ?
>

No, thanks. I'll add that.

Russ

[rsc, 2013-02-09 19:59:29]

Hello golang-dev@googlegroups.com, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-02-09 21:10:47]

https://codereview.appspot.com/7307082/diff/9002/doc/go_spec.html
File doc/go_spec.html (right):

https://codereview.appspot.com/7307082/diff/9002/doc/go_spec.html#newcode5482
doc/go_spec.html:5482: nor packages imported as <code>init</code>.
you could say what is allowed rather than what is prohibited, and flow
differently:

A package-scope or file-scope identifier with name 'init' may only be declared
to be a function with this signature. Multiple such functions may be defined in
a file; they execute in unspecified order.

[rsc, 2013-02-09 23:01:44]

PTAL

[r, 2013-02-10 03:54:16]

LGTM

[rsc, 2013-02-11 12:46:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=e5febb4359bc ***

spec: reject top-level init names

Fixes issue 4586.

R=golang-dev, remyoudompheng, r
CC=golang-dev
https://codereview.appspot.com/7307082