Issue 7307074: remove old build flag for dithered gradients, optimize opaque cache building

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7307074: remove old build flag for dithered gradients, optimize opaque cache building

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by reed1

Modified:
11 years, 2 months ago

Reviewers:
robertphillips, caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

remove old build flag for dithered gradients, optimize opaque cache building

Patch Set 5 : #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -79 lines)			Patch
	M	trunk/src/effects/gradients/SkGradientShader.cpp	View	1 2 3 4	3 chunks	+67 lines, -75 lines	0 comments	Download
	M	trunk/src/effects/gradients/SkGradientShaderPriv.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

https://codereview.appspot.com/7307074/diff/2002/trunk/src/effects/gradients/SkGradientShader.cpp File trunk/src/effects/gradients/SkGradientShader.cpp (right): https://codereview.appspot.com/7307074/diff/2002/trunk/src/effects/gradients/SkGradientShader.cpp#newcode327 trunk/src/effects/gradients/SkGradientShader.cpp:327: do { don't these 0xFF's need to be 'a' ...

11 years, 2 months ago (2013-02-08 16:06:28 UTC) #2

reed1

Ack! patch #5 shows big GM errors in release build, but no errors in debug!? ...

11 years, 2 months ago (2013-02-08 16:42:15 UTC) #3

reed1

11 years, 2 months ago (2013-02-08 19:33:44 UTC) #4

This code, when run on Mac (gcc 4.2.1) or linux (4.6.3) in release build
generates bad code, in that the alpha in the generated colors was 0.

This CL is being abandoned, but preserved so we can track down this error.

Expand All Messages | Collapse All Messages