trivial: fix FloatingIP field types

trivial: fix FloatingIP field types

As discussed before, these two fields of nova.FloatingIP should be
*string, rather than interface{}. It's simpler and more closely
matches the intent.

https://code.launchpad.net/~dimitern/goose/nova-floating-ips-types/+merge/146598

(do not edit description out of merge proposal)

[dimitern, 2013-02-05 10:11:10]

Please take a look.

[jameinel, 2013-02-05 10:33:13]

LGTM

this will be a bit tricky to land because of the ordering, but you can ask me
for help if you want.

[dimitern, 2013-02-05 10:48:37]

As discussed, I'm landing it in the usual through LP MP and the bot.

[rog, 2013-02-05 10:53:23]

LGTM with one small point.

https://codereview.appspot.com/7307046/diff/1/testservices/novaservice/servic...
File testservices/novaservice/service.go (right):

https://codereview.appspot.com/7307046/diff/1/testservices/novaservice/servic...
testservices/novaservice/service.go:596: fip.FixedIP = &fip.IP
i'm not entirely sure if it's alright to have one fip field aliasing another.
probably best to make it point to another place for safety's sake.

[dimitern, 2013-02-05 10:55:45]

post-submit comment

https://codereview.appspot.com/7307046/diff/1/testservices/novaservice/servic...
File testservices/novaservice/service.go (right):

https://codereview.appspot.com/7307046/diff/1/testservices/novaservice/servic...
testservices/novaservice/service.go:596: fip.FixedIP = &fip.IP
On 2013/02/05 10:53:23, rog wrote:
> i'm not entirely sure if it's alright to have one fip field aliasing another.
> probably best to make it point to another place for safety's sake.

I missed that, sorry. I'll make a follow-up.