Issue 7306107: Making a resource subclass and adding datastore model for discovery document in App Engine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7306107: Making a resource subclass and adding datastore model for discovery document in App Engine.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dhermes

Modified:
10 years, 9 months ago

Reviewers:
bossylobster, jcgregorio_google, striker

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Making a resource subclass and adding datastore model for discovery document in App Engine.

Patch Set 2 : Adding back dangling changes from other review. #

Total comments: 1

Patch Set 3 : Syncing review appengine-pickle-resource at 88424276002675bbfb81361a1e450d1d3bbadfd7. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+775 lines, -41 lines)			Patch
A	apiclient/appengine.py	View	1	1 chunk	+281 lines, -0 lines	0 comments	Download
M	apiclient/discovery.py	View	1	6 chunks	+139 lines, -41 lines	0 comments	Download
M	apiclient/model.py	View		2 chunks	+12 lines, -0 lines	0 comments	Download
A	tests/test_apiclient_appengine.py	View	1	1 chunk	+279 lines, -0 lines	0 comments	Download
M	tests/test_discovery.py	View	1	4 chunks	+52 lines, -0 lines	0 comments	Download
M	tests/test_json_model.py	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dhermes

I opened this because I borked the original review: https://codereview.appspot.com/6854090/ This is still pending due ...

11 years, 2 months ago (2013-02-13 21:56:01 UTC) #2

striker

https://codereview.appspot.com/7306107/diff/1005/apiclient/appengine.py File apiclient/appengine.py (right): https://codereview.appspot.com/7306107/diff/1005/apiclient/appengine.py#newcode202 apiclient/appengine.py:202: discovery_doc.put() Can this be put_async() ?

11 years, 2 months ago (2013-02-13 22:36:10 UTC) #4

dhermes

11 years, 2 months ago (2013-02-25 18:53:12 UTC) #5

Syncing review appengine-pickle-resource at
88424276002675bbfb81361a1e450d1d3bbadfd7.

Expand All Messages | Collapse All Messages