Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6709)

Issue 7306106: Recontruction variance on top of GRIC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by sergey.vfx
Modified:
10 years, 7 months ago
Reviewers:
mierle
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This is WIP of recontruction variance criteria applied on top of GRIC.

Patch Set 1 #

Total comments: 2

Patch Set 2 : WIP patch, stage 2 #

Patch Set 3 : WIP patch, stage 3 #

Patch Set 4 : Patch Set 3 : WIP patch, stage 4 #

Total comments: 2

Patch Set 5 : WIP patch, stage 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+937 lines, -93 lines) Patch
extern/libmv/CMakeLists.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
extern/libmv/ChangeLog View 1 2 3 4 2 chunks +63 lines, -52 lines 0 comments Download
extern/libmv/files.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
extern/libmv/libmv-capi.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
extern/libmv/libmv-capi.cpp View 1 2 3 4 5 chunks +81 lines, -6 lines 0 comments Download
extern/libmv/libmv/multiview/fundamental.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
extern/libmv/libmv/multiview/fundamental.cc View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/bundle.h View 1 2 3 4 5 chunks +34 lines, -2 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/bundle.cc View 1 2 3 4 4 chunks +84 lines, -2 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/initialize_reconstruction.cc View 1 2 3 4 1 chunk +2 lines, -14 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/intersect.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/keyframe_selection.cc View 1 2 3 4 1 chunk +595 lines, -0 lines 0 comments Download
extern/libmv/libmv/simple_pipeline/pipeline.cc View 1 2 3 4 1 chunk +7 lines, -3 lines 0 comments Download
release/scripts/startup/bl_ui/space_clip.py View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
source/blender/blenkernel/intern/tracking.c View 1 2 3 4 7 chunks +28 lines, -11 lines 0 comments Download
source/blender/makesdna/DNA_tracking_types.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
source/blender/makesrna/intern/rna_tracking.c View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11
sergey.vfx
11 years, 2 months ago (2013-02-13 21:23:02 UTC) #1
sergey.vfx
WIP patch, stage 2
11 years, 2 months ago (2013-02-27 09:00:52 UTC) #2
sergey.vfx
Added second stage of WIP patch. Changes: - Switched H, F refining to normalized space. ...
11 years, 2 months ago (2013-02-27 09:04:00 UTC) #3
sergey.vfx
WIP patch, stage 3
11 years, 1 month ago (2013-03-05 18:15:32 UTC) #4
sergey.vfx
Made it full patch against trunk. Since last patch i've ordered parameters and tried to ...
11 years, 1 month ago (2013-03-05 18:17:08 UTC) #5
sergey.vfx
Patch Set 3 : WIP patch, stage 4
11 years, 1 month ago (2013-03-06 18:26:39 UTC) #6
sergey.vfx
Changes: - Made it more generic way of getting minimizer's information from BA (like number ...
11 years, 1 month ago (2013-03-06 18:30:25 UTC) #7
sergey.vfx
On 2013/03/06 18:30:25, sergey.vfx wrote: > Changes: > - Made it more generic way of ...
11 years, 1 month ago (2013-03-06 18:44:00 UTC) #8
mierle
https://codereview.appspot.com/7306106/diff/1/extern/libmv/libmv/simple_pipeline/intersect.cc File extern/libmv/libmv/simple_pipeline/intersect.cc (right): https://codereview.appspot.com/7306106/diff/1/extern/libmv/libmv/simple_pipeline/intersect.cc#newcode68 extern/libmv/libmv/simple_pipeline/intersect.cc:68: 80 columns https://codereview.appspot.com/7306106/diff/1/extern/libmv/libmv/simple_pipeline/keyframe_selection.cc File extern/libmv/libmv/simple_pipeline/keyframe_selection.cc (right): https://codereview.appspot.com/7306106/diff/1/extern/libmv/libmv/simple_pipeline/keyframe_selection.cc#newcode350 extern/libmv/libmv/simple_pipeline/keyframe_selection.cc:350: + ...
11 years, 1 month ago (2013-03-13 07:17:43 UTC) #9
sergey.vfx
WIP patch, stage 5
11 years ago (2013-04-23 20:31:59 UTC) #10
sergey.vfx
11 years ago (2013-04-23 20:38:30 UTC) #11
Comparing to previous patchset:

- Better epsilon handing in pseudoInverse function. Now it uses the same
tolerance as NumPy does.
- Made it better covariance matrix estimation, using generalized inverse with N
eigen values zeroed (N=7 in our case).
- Made it return single keyframe pair, which is detecting based on
reconstruction estimation. Previous code to do full reconstruction of 2 frames
didn't work well. Also, apparently average reprojection error could be the same
for bad and good keyframe pair.
- Made it so EuclideanIntersect returns false in case point is behind the
camera.

Seems to behave better than bare GRIC, but still need to do:
- Make solution "permanent" size -- that thing to eliminate scale indeterminacy.
- Use sparse matrix for bundler evaluation and pseudo-inverse. Shall give some
boost.

I'm actually pretty much close to commit this stuff to tomato branch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b