Issue 7305101: state/api: implement Client.ServiceSet

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
dimitern, mp+149367, fwereade

Visibility:
Public.

Description

state/api: implement Client.ServiceSet This CL makes use of the earlier branch that factored the meat of the command out from juju/cmd. Also added Client.ServiceSetYAML, as requested. https://code.launchpad.net/~rogpeppe/juju-core/227-api-config-set-2/+merge/149367 Requires: https://code.launchpad.net/~rogpeppe/juju-core/224-api-config-set/+merge/149329 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: implement Client.SetConfig #

Total comments: 2

Patch Set 3 : state/api: implement Client.SetConfig #

Patch Set 4 : state/api: implement Client.SetConfig #

Patch Set 5 : state/api: implement Client.SetConfig #

Patch Set 6 : state/api: implement Client.SetConfig #

Patch Set 7 : state/api: implement Client.SetConfig #

Patch Set 8 : state/api: implement Client.SetConfig #

Patch Set 9 : state/api: implement Client.ServiceSet #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -0 lines)			Patch
A	[revision details]	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/api_test.go	View	1 2 3 4 5 6 7 8	3 chunks	+64 lines, -0 lines	0 comments	Download
M	state/api/apiclient.go	View	1 2 3 4	1 chunk	+21 lines, -0 lines	0 comments	Download
M	state/api/apiserver.go	View	1 2 3 4	1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/api/export_test.go	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

fwereade

LGTM, conditional on appropriate changes being made in the prereq (dropping yaml param, turning options ...

11 years, 2 months ago (2013-02-20 08:04:58 UTC) #2

dimitern

LGTM https://codereview.appspot.com/7305101/diff/2001/state/api/apiserver.go File state/api/apiserver.go (right): https://codereview.appspot.com/7305101/diff/2001/state/api/apiserver.go#newcode193 state/api/apiserver.go:193: func (c *srvClient) SetConfig(p statecmd.SetConfigParams) error { Comment ...

11 years, 2 months ago (2013-02-21 11:27:02 UTC) #3

rog

Please take a look. https://codereview.appspot.com/7305101/diff/2001/state/api/apiserver.go File state/api/apiserver.go (right): https://codereview.appspot.com/7305101/diff/2001/state/api/apiserver.go#newcode193 state/api/apiserver.go:193: func (c *srvClient) SetConfig(p statecmd.SetConfigParams) ...

11 years, 2 months ago (2013-02-26 18:37:46 UTC) #4

rog

11 years, 2 months ago (2013-02-27 10:32:44 UTC) #7

*** Submitted:

state/api: implement Client.ServiceSet

This CL makes use of the earlier branch
that factored the meat of the command
out from juju/cmd.

Also added Client.ServiceSetYAML, as requested.

R=fwereade, dimitern
CC=
https://codereview.appspot.com/7305101

Expand All Messages | Collapse All Messages