Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1289)

Issue 7305060: size_limit_ member of minidump_descriptor ignored in copy constructor

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by avishai.hendel
Modified:
9 years, 3 months ago
Reviewers:
mkrebs, ted, ted
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

size_limit_ member of minidump_descriptor ignored in copy constructor

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/client/linux/handler/minidump_descriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/handler/minidump_descriptor.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
avishai.hendel
Hey, size_limit_ member of minidump_descriptor was ignored in copy constructor, assignment operator and the default ...
11 years, 1 month ago (2013-02-07 19:57:54 UTC) #1
mkrebs
LGTM
11 years, 1 month ago (2013-02-08 22:28:24 UTC) #2
avishai.hendel
On 2013/02/08 22:28:24, mkrebs wrote: > LGTM How do I push this diff?
11 years, 1 month ago (2013-02-13 23:11:25 UTC) #3
ted
11 years, 1 month ago (2013-02-14 14:01:40 UTC) #4
Sorry, forgot about this. I'll push it for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b