Issue 7305060: size_limit_ member of minidump_descriptor ignored in copy constructor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by avishai.hendel

Modified:
10 years, 2 months ago

Reviewers:
mkrebs, ted, ted

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

size_limit_ member of minidump_descriptor ignored in copy constructor

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/client/linux/handler/minidump_descriptor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/client/linux/handler/minidump_descriptor.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 4

avishai.hendel

Hey, size_limit_ member of minidump_descriptor was ignored in copy constructor, assignment operator and the default ...

12 years ago (2013-02-07 19:57:54 UTC) #1

avishai.hendel

On 2013/02/08 22:28:24, mkrebs wrote: > LGTM How do I push this diff?

12 years ago (2013-02-13 23:11:25 UTC) #3

Sorry, forgot about this. I'll push it for you.