Use source maps.

Use source maps.



https://code.launchpad.net/~benji/juju-gui/bug-1110823-add-source-maps/+merge/146721

(do not edit description out of merge proposal)

[benji, 2013-02-05 20:59:24]

Please take a look.

[matthew.scott, 2013-02-05 22:05:54]

Looks good to me, tested out in Chrome, thanks for the work!

[gary.poster, 2013-02-05 22:45:59]

Land with changes.

Cool!  Thank you.

Please feel free to treat my question about spawning as a request for a comment
rather than a request for an actual change (unless it inspires you thusly).

Gary

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js
File lib/merge-files.js (right):

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode16
lib/merge-files.js:16: function minify(file, compressorType) {
Why did you keep this no-op here?

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode44
lib/merge-files.js:44: var uglify = child_process.spawn(UGLIFY, options, {stdio:
'inherit'});
Why do we need to spawn this instead of requiring the code and using it inline?

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode143
lib/merge-files.js:143: filter: 'RAW', // We do not want minified source.
Maybe add "because we minify it in uglify, when we also produce the sourcemaps"

[benji, 2013-02-06 15:29:46]

Good stuff.  I have integrated all the suggestions and intend to merge the
branch.

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js
File lib/merge-files.js (right):

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode16
lib/merge-files.js:16: function minify(file, compressorType) {
On 2013/02/05 22:45:59, gary.poster wrote:
> Why did you keep this no-op here?

Because of things... and stuff.


Fixed. ;)

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode44
lib/merge-files.js:44: var uglify = child_process.spawn(UGLIFY, options, {stdio:
'inherit'});
On 2013/02/05 22:45:59, gary.poster wrote:
> Why do we need to spawn this instead of requiring the code and using it
inline?

That is a good idea.  I have implemented it.

https://codereview.appspot.com/7305047/diff/1/lib/merge-files.js#newcode143
lib/merge-files.js:143: filter: 'RAW', // We do not want minified source.
On 2013/02/05 22:45:59, gary.poster wrote:
> Maybe add "because we minify it in uglify, when we also produce the
sourcemaps"

Done.

[benji, 2013-02-06 17:39:05]

Please take a look.

[benji, 2013-02-06 17:42:12]

*** Submitted:

Use source maps.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7305047