Issue 7304102: code review 7304102: runtime: ensure forward progress of runtime.Gosched() f...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7304102: code review 7304102: runtime: ensure forward progress of runtime.Gosched() f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by dvyukov

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, brainman, rsc

Visibility:
Public.

Description

runtime: ensure forward progress of runtime.Gosched() for locked goroutines The removed code leads to the situation when M executes the same locked G again and again. This is https://codereview.appspot.com/7310096 but with return instead of break in the nested switch. Fixes issue 4820.

Patch Set 1 #

Patch Set 2 : diff -r 0adf91947752 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 0adf91947752 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 28d951917340 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -8 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
	M	src/pkg/runtime/proc_test.go	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 2 months ago (2013-02-17 07:15:32 UTC) #1

dvyukov

12 years, 2 months ago (2013-02-20 08:13:25 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=1f57ae2a3e1c ***

runtime: ensure forward progress of runtime.Gosched() for locked goroutines
The removed code leads to the situation when M executes the same locked G again
and again.
This is https://codereview.appspot.com/7310096 but with return instead of break
in the nested switch.
Fixes issue 4820.

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://codereview.appspot.com/7304102

Expand All Messages | Collapse All Messages