code review 7304089: go/types: print, println accept 0 or more arguments

go/types: print, println accept 0 or more arguments

[gri, 2013-02-13 02:10:21]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2013-02-13 02:11:53]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adonovan, 2013-02-13 03:08:13]

LGTM.

(FWIW, the arity of print and println are nowhere specified, so the old
code was arguably just as correct.)


2013/2/12 <gri@golang.org>

> Hello adonovan@google.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/7304089/<https://codereview.appspot.com/7304...
>

[gri, 2013-02-13 03:10:38]

No, that's not correct. The arity is defined in universe.go, which I
adjusted. I found this bug because the old code didn't accept a
print().
- gri

On Tue, Feb 12, 2013 at 7:08 PM, Alan Donovan <adonovan@google.com> wrote:
> LGTM.
>
> (FWIW, the arity of print and println are nowhere specified, so the old code
> was arguably just as correct.)
>
>
> 2013/2/12 <gri@golang.org>
>
>> Hello adonovan@google.com (cc: golang-dev@googlegroups.com),
>>
>> Please take another look.
>>
>>
>> https://codereview.appspot.com/7304089/
>
>

[gri, 2013-02-13 03:40:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=3b702853541b ***

go/types: print, println accept 0 or more arguments

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7304089

[adonovan, 2013-02-13 04:50:54]

(I meant: not specified in the language spec.)


On 12 February 2013 22:10, Robert Griesemer <gri@golang.org> wrote:

> No, that's not correct. The arity is defined in universe.go, which I
> adjusted. I found this bug because the old code didn't accept a
> print().
> - gri
>
> On Tue, Feb 12, 2013 at 7:08 PM, Alan Donovan <adonovan@google.com> wrote:
> > LGTM.
> >
> > (FWIW, the arity of print and println are nowhere specified, so the old
> code
> > was arguably just as correct.)
> >
> >
> > 2013/2/12 <gri@golang.org>
> >
> >> Hello adonovan@google.com (cc: golang-dev@googlegroups.com),
> >>
> >> Please take another look.
> >>
> >>
> >> https://codereview.appspot.com/7304089/
> >
> >
>