Issue 7303101: trivial: fix openstack local test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7303101: trivial: fix openstack local test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dimitern

Modified:
11 years, 2 months ago

Reviewers:
mp+149242

Visibility:
Public.

Description

trivial: fix openstack local test TestInstanceGathering in environs/openstack/local_test.go failed if run on its own, because it needs a bootstrapped environment (which other tests provide, when all of them are run). This fixes the test, so it calls BootstrapOnce, thus it passes both on its own and with other tests. https://code.launchpad.net/~dimitern/juju-core/openstack-fix-instance-gathering/+merge/149242 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : trivial: fix openstack local test #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/openstack/local_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

I don't think you want the extra whitespace, but I do think this needs to ...

11 years, 2 months ago (2013-02-19 11:12:32 UTC) #2

dimitern

11 years, 2 months ago (2013-02-19 11:14:22 UTC) #3

*** Submitted:

trivial: fix openstack local test

TestInstanceGathering in environs/openstack/local_test.go
failed if run on its own, because it needs a bootstrapped
environment (which other tests provide, when all of them
are run). This fixes the test, so it calls BootstrapOnce,
thus it passes both on its own and with other tests.

R=jameinel
CC=
https://codereview.appspot.com/7303101

Expand All Messages | Collapse All Messages