Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 7303090: code review 7303090: misc/dashboard/builder: record build result on dashboard (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dave
Modified:
12 years, 3 months ago
Reviewers:
CC:
adg, golang-dev
Visibility:
Public.

Description

misc/dashboard/builder: record build result on dashboard This is part one of two changes intended to make it easier to debug builder failures. runOutput allows us to control the io.Writer passed to a subcommand. The intention is to add additional debugging information before and after the build which will then be capture and sent to the dashboard. In this proposal, the only additional information is the build status. See http://build.golang.org/log/e7b5bf435b4de1913fc61781b3295fb3f03aeb6e

Patch Set 1 #

Patch Set 2 : diff -r 9b7b9fa92d2c https://code.google.com/p/go #

Patch Set 3 : diff -r 9b7b9fa92d2c https://code.google.com/p/go #

Patch Set 4 : diff -r a394d9eeb49a https://code.google.com/p/go #

Patch Set 5 : diff -r a394d9eeb49a https://code.google.com/p/go #

Patch Set 6 : diff -r d1f3875bb043 https://code.google.com/p/go #

Patch Set 7 : diff -r d1f3875bb043 https://code.google.com/p/go #

Patch Set 8 : diff -r d1f3875bb043 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -37 lines) Patch
M misc/dashboard/builder/exec.go View 1 2 1 chunk +20 lines, -24 lines 0 comments Download
M misc/dashboard/builder/main.go View 1 2 3 4 5 6 7 6 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-02-14 09:09:42 UTC) #1
adg
LGTM Thanks.
12 years, 3 months ago (2013-02-14 23:29:01 UTC) #2
dave_cheney.net
Thanks. In followup CLs I'd like to use this facility to log a few details ...
12 years, 3 months ago (2013-02-14 23:32:12 UTC) #3
dave_cheney.net
12 years, 3 months ago (2013-02-14 23:44:49 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=33288fcef022 ***

misc/dashboard/builder: record build result on dashboard

This is part one of two changes intended to make it easier to debug builder
failures.

runOutput allows us to control the io.Writer passed to a subcommand. The
intention is to add additional debugging information before and after the build
which will then be capture and sent to the dashboard.

In this proposal, the only additional information is the build status. See
http://build.golang.org/log/e7b5bf435b4de1913fc61781b3295fb3f03aeb6e

R=adg
CC=golang-dev
https://codereview.appspot.com/7303090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b