Issue 7303064: code review 7303064: spec: clarify that any unsafe.Pointer type is okay in c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7303064: code review 7303064: spec: clarify that any unsafe.Pointer type is okay in c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

spec: clarify that any unsafe.Pointer type is okay in conversion The spec is not clear about whether this is allowed or not, but both compilers allow it, because the reflect implementation takes advantage of it. Document current behavior. Fixes issue 4679.

Patch Set 1 #

Patch Set 2 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e8eb2c8d5ce1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5c213525c4b5 https://code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	1 chunk	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 4 months ago (2013-02-09 19:32:38 UTC) #1

rsc

12 years, 4 months ago (2013-02-09 22:36:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a44171137af8 ***

spec: clarify that any unsafe.Pointer type is okay in conversion

The spec is not clear about whether this is allowed or not,
but both compilers allow it, because the reflect implementation
takes advantage of it. Document current behavior.

Fixes issue 4679.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7303064

Expand All Messages | Collapse All Messages