Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 7301086: code review 7301086: misc/vim: update installation instructions to work bett... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by dsymonds
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

misc/vim: update installation instructions to work better with some Linux distributions. Fixes issue 3308.

Patch Set 1 #

Patch Set 2 : diff -r 140452485d03 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 140452485d03 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 10534bf6553f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M misc/vim/readme.txt View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago (2013-02-13 03:11:06 UTC) #1
minux1
https://codereview.appspot.com/7301086/diff/5001/misc/vim/readme.txt File misc/vim/readme.txt (right): https://codereview.appspot.com/7301086/diff/5001/misc/vim/readme.txt#newcode10 misc/vim/readme.txt:10: set runtimepath+=$GOROOT/misc/vim most people won't set GOROOT these days, ...
13 years, 1 month ago (2013-02-13 16:35:27 UTC) #2
dsymonds
https://codereview.appspot.com/7301086/diff/5001/misc/vim/readme.txt File misc/vim/readme.txt (right): https://codereview.appspot.com/7301086/diff/5001/misc/vim/readme.txt#newcode10 misc/vim/readme.txt:10: set runtimepath+=$GOROOT/misc/vim On 2013/02/13 16:35:28, minux wrote: > most ...
13 years, 1 month ago (2013-02-13 22:09:04 UTC) #3
minux1
On Thursday, February 14, 2013, dsymonds wrote: > > Sure, but hopefully people can figure ...
13 years, 1 month ago (2013-02-18 02:47:04 UTC) #4
adg
LGTM
13 years, 1 month ago (2013-02-18 03:03:38 UTC) #5
dsymonds
13 years, 1 month ago (2013-02-18 03:03:58 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=f30bdd45914c ***

misc/vim: update installation instructions to work better with some Linux
distributions.

Fixes issue 3308.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7301086
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b