testing/repo: remove symlinks from dummy charm

testing/repo: remove symlinks from dummy charm

This changes the testing charms so that they don't have a symlink
in the source tree. For tests that want to test bundling symlinks,
we just add them on-demand in the newly created bundle dir.

Coupled with the 'no-symlinks' patch, this removes all symlinks
from the source tree, allowing us to checkout lp:juju-core on
platforms that don't support them.

https://code.launchpad.net/~jameinel/juju-core/charm-symlinks/+merge/147877

(do not edit description out of merge proposal)

[jameinel, 2013-02-12 10:25:22]

Please take a look.

[dimitern, 2013-02-13 10:50:31]

LGTM. I'll merge your changes, if this lands before my branch about bug #864164.

[gz, 2013-02-13 11:45:05]

LGTM

https://codereview.appspot.com/7301080/diff/1/charm/bundle_test.go
File charm/bundle_test.go (right):

https://codereview.appspot.com/7301080/diff/1/charm/bundle_test.go#newcode81
charm/bundle_test.go:81: var haveSymlinks = true
Seems this should either be a more global flag named haveSymlinks that's just
about symlink before, or be a flag about if this particular symlink for the test
exists and named differently.

[dave_cheney.net, 2013-02-17 22:34:12]

LGTM with minor comments.

https://codereview.appspot.com/7301080/diff/1/charm/bundle_test.go
File charm/bundle_test.go (right):

https://codereview.appspot.com/7301080/diff/1/charm/bundle_test.go#newcode77
charm/bundle_test.go:77: if err != nil {
if err := os.Chmod(filepath.Join(srcPath, m.path), m.mode); err != nil {
    c.Assert(err, IsNil)
}

https://codereview.appspot.com/7301080/diff/1/charm/dir_test.go
File charm/dir_test.go (right):

https://codereview.appspot.com/7301080/diff/1/charm/dir_test.go#newcode39
charm/dir_test.go:39: var haveSymlinks = true
This is a test for windows right ? why not do 

const haveSymlinks = runtime.GOOS == "windows"

[jameinel, 2013-02-19 07:50:44]

*** Submitted:

testing/repo: remove symlinks from dummy charm

This changes the testing charms so that they don't have a symlink
in the source tree. For tests that want to test bundling symlinks,
we just add them on-demand in the newly created bundle dir.

Coupled with the 'no-symlinks' patch, this removes all symlinks
from the source tree, allowing us to checkout lp:juju-core on
platforms that don't support them.

R=dimitern, gz, dfc
CC=
https://codereview.appspot.com/7301080

https://codereview.appspot.com/7301080/diff/1/charm/dir_test.go
File charm/dir_test.go (right):

https://codereview.appspot.com/7301080/diff/1/charm/dir_test.go#newcode39
charm/dir_test.go:39: var haveSymlinks = true
It wasn't specifically about Windows, though that is the platform where this
becomes necessary. It also happens if you were doing something like running the
test suite inside of a fat32 partition, etc.

Certainly we could do it with an OS test, but it made the most sense to me to
try to create a symlink, if you can't, then don't do the symlink portion of the
test.