Descriptionnova: Refactor Filter
Now nova client and test double use separate filter types for better
isolation and simple code: nova.Filter (by the client), having only
Set() as it's write-only; and novaservice.filter (by the double), being
a thin wrapper over map[string]string.
As discussed, this relays the intent better and makes code cleaner.
Also removed a now redundant test to compare Add() and Set() on nova.Filter
and updated all tests as needed.
https://code.launchpad.net/~dimitern/goose/nova-filter-refactoring/+merge/147371
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 8
Patch Set 2 : nova: Refactor Filter #Patch Set 3 : nova: Refactor Filter #
Total comments: 5
Patch Set 4 : nova: Refactor Filter #Patch Set 5 : nova: Refactor Filter #Patch Set 6 : nova: Refactor Filter #
MessagesTotal messages: 10
|