Issue 7300102: code review 7300102: go.net/ipv4: simplify, drop unnecessary parentheses and...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7300102: code review 7300102: go.net/ipv4: simplify, drop unnecessary parentheses and... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by mikio

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

go.net/ipv4: simplify, drop unnecessary parentheses and slice indices

Patch Set 1 #

Patch Set 2 : diff -r ffbff9f7596e https://code.google.com/p/go.net #

Patch Set 3 : diff -r ffbff9f7596e https://code.google.com/p/go.net #

Patch Set 4 : diff -r ffbff9f7596e https://code.google.com/p/go.net #

Patch Set 5 : diff -r ffbff9f7596e https://code.google.com/p/go.net #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	ipv4/control_linux.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ipv4/header.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ipv4/packet.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

12 years, 1 month ago (2013-02-13 10:30:50 UTC) #1

mikio

12 years, 1 month ago (2013-02-13 22:01:24 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=12cbee8e4916&repo=net ***

go.net/ipv4: simplify, drop unnecessary parentheses and slice indices

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7300102

Expand All Messages | Collapse All Messages