code review 7300081: net: set up IPv6 scoped addressing zone for network fac...

net: set up IPv6 scoped addressing zone for network facilities

This CL changes nothing to existing API behavior, just sets up
Zone in IPNet and IPAddr structures if possible.

Also does small simplification.

Update issue 4234.

[mikio, 2013-02-11 12:55:54]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-02-15 11:58:06]

Thank you, I think this is very close. 

Does it need a test for the new Zone setting behavior.

I think this CL could have been a lot smaller without the changes to switch
statements. In the future, could you please separate out CLs that just cleanup
the source. Thanks.

https://codereview.appspot.com/7300081/diff/9006/src/pkg/net/interface_window...
File src/pkg/net/interface_windows.go (right):

https://codereview.appspot.com/7300081/diff/9006/src/pkg/net/interface_window...
src/pkg/net/interface_windows.go:78: // TODO: Implement IPv6 stuff
could you be a little more descriptive here please

https://codereview.appspot.com/7300081/diff/9006/src/pkg/net/interface_window...
src/pkg/net/interface_windows.go:143: // TODO: Implement IPv6 stuff
same

https://codereview.appspot.com/7300081/diff/9006/src/pkg/net/interface_window...
src/pkg/net/interface_windows.go:159: // TODO: Implement this
same, also TODO(mikioh)

[mikio, 2013-02-16 05:00:09]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2013-02-16 05:06:36]

PTAL.

> Does it need a test for the new Zone setting behavior.

nope, for now. also CL 6816116 contains such tests.

> I think this CL could have been a lot smaller without the changes to switch
> statements. In the future, could you please separate out CLs that just cleanup
> the source. Thanks.

my bad, thx.

[dave_cheney.net, 2013-02-17 00:25:14]

LGTM providing there is a decision on issue
https://code.google.com/p/go/issues/detail?id=4501

[mikio, 2013-02-17 06:01:37]

Russ?

I think this CL doesn't step across the Rubicon yet and easy to revert,
together with existing Zone stuff (by manual).

On Sun, Feb 17, 2013 at 9:25 AM,  <dave@cheney.net> wrote:
> LGTM providing there is a decision on issue
> https://code.google.com/p/go/issues/detail?id=4501
>
> https://codereview.appspot.com/7300081/

[rsc, 2013-02-19 15:20:31]

LGTM

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux.go
File src/pkg/net/interface_linux.go (right):

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux...
src/pkg/net/interface_linux.go:32: break done
done is weird label for a for loop. If you want to use a labeled break, please
use a label like Loop or MessageLoop.

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux...
src/pkg/net/interface_linux.go:116: break done
Same.

[mikio, 2013-02-19 23:18:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=a81ef8e0cc05 ***

net: set up IPv6 scoped addressing zone for network facilities

This CL changes nothing to existing API behavior, just sets up
Zone in IPNet and IPAddr structures if possible.

Also does small simplification.

Update issue 4234.

R=rsc, dave
CC=golang-dev
https://codereview.appspot.com/7300081

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux.go
File src/pkg/net/interface_linux.go (right):

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux...
src/pkg/net/interface_linux.go:32: break done
On 2013/02/19 15:20:31, rsc wrote:
> done is weird label for a for loop. If you want to use a labeled break, please
> use a label like Loop or MessageLoop.

Done.

https://codereview.appspot.com/7300081/diff/14001/src/pkg/net/interface_linux...
src/pkg/net/interface_linux.go:116: break done
On 2013/02/19 15:20:31, rsc wrote:
> Same.

Done.