Browser test speed and reporting improvements.

Browser test speed and reporting improvements.

- test runs print a URL where job details can be viewed
- only one browser session is created for the entire test run, as opposed to
  one *per test* before
- the user name of the current user is added to the test run as a tag

https://code.launchpad.net/~benji/juju-gui/bug-1116274-show-saucelabs-links/+merge/146951

(do not edit description out of merge proposal)

[benji, 2013-02-06 20:36:23]

Please take a look.

[gary.poster, 2013-02-06 20:58:27]

Land with changes.

Thank you!

Gary

https://codereview.appspot.com/7300054/diff/1/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode57
test/browser.py:57: """Helper base class that supports runing browser tests."""
While converting browser tests into runes sounds interesting... :-)

typo: running

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode61
test/browser.py:61: global driver # We only want one because they are expensive
to set up.
Could also be class attribute, slightly simplifying setUp.  <shrug>

Oh! You want all subclass instances to use this!  Got it, never mind.

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode69
test/browser.py:69: capabilities['tags'] = [user]
In CI this will always be the Jenkins user.  I guess this is nice to find your
own test results though, when this is used standalone.

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode74
test/browser.py:74: driver.session_id)
Cool.

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode87
test/browser.py:87: set_test_result(driver.session_id, successful)
Could do https://bugs.launchpad.net/juju-gui/+bug/1116698/comments/1 if you
wanted.  Would give you isolation not only across test cases, but also across
tests.  Starting up improv isn't super cheap--five or ten seconds--but not too
bad.

Alternatively, could put it in tearDownClass?

maybe a separate card.

[benji, 2013-02-06 21:05:23]

Thanks for the review.  Fixes applied.

https://codereview.appspot.com/7300054/diff/1/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode57
test/browser.py:57: """Helper base class that supports runing browser tests."""
On 2013/02/06 20:58:27, gary.poster wrote:
> While converting browser tests into runes sounds interesting... :-)
> 
> typo: running

Done.

https://codereview.appspot.com/7300054/diff/1/test/browser.py#newcode87
test/browser.py:87: set_test_result(driver.session_id, successful)
On 2013/02/06 20:58:27, gary.poster wrote:
> Could do https://bugs.launchpad.net/juju-gui/+bug/1116698/comments/1 if you
> wanted.  Would give you isolation not only across test cases, but also across
> tests.  Starting up improv isn't super cheap--five or ten seconds--but not too
> bad.
> 
> Alternatively, could put it in tearDownClass?
> 
> maybe a separate card.

I lean toward a separate card because I would like us to implement that bit when
we have real tests.  That way we can get a better idea of when and how we want
to do the resetting.

[matthew.scott, 2013-02-06 21:14:01]

Looks good to me with Gary's comments addressed (which I just saw...).  Works
well.

Thanks!

[benji, 2013-02-06 21:15:32]

On Wed, Feb 6, 2013 at 9:14 PM,  <matthew.scott@canonical.com> wrote:
> Looks good to me with Gary's comments addressed (which I just saw...).
> Works well.

Thanks for the review!
-- 
Benji York

[benji, 2013-02-06 21:17:50]

*** Submitted:

Browser test speed and reporting improvements.

- test runs print a URL where job details can be viewed
- only one browser session is created for the entire test run, as opposed to
  one *per test* before
- the user name of the current user is added to the test run as a tag

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7300054