code review 7300045: exp/inotify: close event channel before file descriptor

exp/inotify: close event channel before file descriptor

Closing the inotify file descriptor can take over a second
when running on Ubuntu Precise in an NFS directory, leading to
the test error in issue 3132.  Closing the event channel first
lets a client that does not care about the error channel move
on.

Fixes issue 3132.

[iant, 2013-02-05 07:01:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-02-05 07:04:54]

LGTM.

https://codereview.appspot.com/7300045/diff/1/src/pkg/exp/inotify/inotify_lin...
File src/pkg/exp/inotify/inotify_linux.go (right):

https://codereview.appspot.com/7300045/diff/1/src/pkg/exp/inotify/inotify_lin...
src/pkg/exp/inotify/inotify_linux.go:156: n, err := syscall.Read(w.fd, buf[0:])
buf[:]

[rsc, 2013-02-05 12:14:01]

LGTM

[iant, 2013-02-05 14:07:25]

https://codereview.appspot.com/7300045/diff/1/src/pkg/exp/inotify/inotify_lin...
File src/pkg/exp/inotify/inotify_linux.go (right):

https://codereview.appspot.com/7300045/diff/1/src/pkg/exp/inotify/inotify_lin...
src/pkg/exp/inotify/inotify_linux.go:156: n, err := syscall.Read(w.fd, buf[0:])
On 2013/02/05 07:04:54, dfc wrote:
> buf[:]

Done.

[iant, 2013-02-05 14:11:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=a9211b512258 ***

exp/inotify: close event channel before file descriptor

Closing the inotify file descriptor can take over a second
when running on Ubuntu Precise in an NFS directory, leading to
the test error in issue 3132.  Closing the event channel first
lets a client that does not care about the error channel move
on.

Fixes issue 3132.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/7300045