Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3230)

Issue 7299057: Fixed browser testing.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by frankban
Modified:
11 years, 1 month ago
Reviewers:
mp+146850
Visibility:
Public.

Description

Fixed browser testing. Trivial fix + code lint and pep8. https://code.launchpad.net/~frankban/juju-gui/browser-tests-fix/+merge/146850 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixed browser testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/deploy_charm_for_testing.py View 2 chunks +2 lines, -2 lines 0 comments Download
M test/browser.py View 2 chunks +1 line, -1 line 0 comments Download
M test/test_deploy_charm_for_testing.py View 6 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
11 years, 1 month ago (2013-02-06 12:58:24 UTC) #1
benji
Looks good.
11 years, 1 month ago (2013-02-06 13:04:06 UTC) #2
gary.poster
Land as is. Thanks Gary
11 years, 1 month ago (2013-02-06 13:09:58 UTC) #3
frankban
11 years, 1 month ago (2013-02-06 14:04:49 UTC) #4
*** Submitted:

Fixed browser testing.

Trivial fix + code lint and pep8.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7299057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b