Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1113)

Issue 7299055: code review 7299055: runtime: fix build for Linux/ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by minux1
Modified:
11 years, 3 months ago
Reviewers:
CC:
dave_cheney.net, rsc, golang-dev
Visibility:
Public.

Description

runtime: fix build for Linux/ARM

Patch Set 1 #

Patch Set 2 : diff -r 8d71734a0cb0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 28966b7b2f0c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/pkg/runtime/traceback_arm.c View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8
minux1
Hello dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 3 months ago (2013-02-06 00:36:44 UTC) #1
dave_cheney.net
Thanks, testing now.
11 years, 3 months ago (2013-02-06 00:41:23 UTC) #2
minux1
Please note that FreeBSD/ARM build will also be broken by the same CL that breaks ...
11 years, 3 months ago (2013-02-06 00:44:37 UTC) #3
dave_cheney.net
Understood, when I start winning the war of keeping builders online, I'll be sure to ...
11 years, 3 months ago (2013-02-06 00:45:26 UTC) #4
dave_cheney.net
Tests pass on my builder but I don't feel qualified to assert more than that. ...
11 years, 3 months ago (2013-02-06 01:15:47 UTC) #5
minux1
On Wed, Feb 6, 2013 at 9:15 AM, Dave Cheney <dave@cheney.net> wrote: > Tests pass ...
11 years, 3 months ago (2013-02-06 01:21:20 UTC) #6
rsc
LGTM
11 years, 3 months ago (2013-02-07 23:43:26 UTC) #7
minux1
11 years, 3 months ago (2013-02-08 05:24:52 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=c224c490576b ***

runtime: fix build for Linux/ARM

R=dave, rsc
CC=golang-dev
https://codereview.appspot.com/7299055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b