Issue 7299045: openstack: fix nova.FloatingIP fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7299045: openstack: fix nova.FloatingIP fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dimitern

Modified:
11 years, 3 months ago

Reviewers:
mp+146599

Visibility:
Public.

Description

openstack: fix nova.FloatingIP fields Changed InstanceId and FixedIP handling to reflect goose changes in: https://codereview.appspot.com/7307046 This is just a trivial change. https://code.launchpad.net/~dimitern/juju-core/nova-floating-ips-types/+merge/146599 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : openstack: fix nova.FloatingIP fields #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/openstack/provider.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2013/02/05 10:18:56, dimitern wrote: > Please take a look. LGTM

11 years, 3 months ago (2013-02-05 10:46:04 UTC) #3

dimitern

11 years, 3 months ago (2013-02-05 10:47:11 UTC) #4

*** Submitted:

openstack: fix nova.FloatingIP fields

Changed InstanceId and FixedIP handling to reflect goose changes in:
https://codereview.appspot.com/7307046

This is just a trivial change.

R=jameinel, rog
CC=
https://codereview.appspot.com/7299045

Expand All Messages | Collapse All Messages