Issue 7293043: code review 7293043: net: prevent races during windows lookup calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7293043: code review 7293043: net: prevent races during windows lookup calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by brainman

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
rsc, bradfitz, golang-dev

Visibility:
Public.

Description

net: prevent races during windows lookup calls This only affects code (with exception of lookupProtocol) that is only executed on older versions of Windows.

Patch Set 1 #

Patch Set 2 : diff -r 575df914948c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 575df914948c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a8d940d69a3e https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -17 lines)			Patch
	M	src/pkg/net/lookup_windows.go	View	1	6 chunks	+59 lines, -17 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-02-04 01:48:43 UTC) #1

bradfitz

Cute. :-) On Feb 3, 2013 6:01 PM, <rsc@golang.org> wrote: > LGTM > > I ...

11 years, 3 months ago (2013-02-04 02:02:33 UTC) #3

brainman

On 2013/02/04 02:02:33, bradfitz wrote: > Cute. :-) > ... I just did what Russ ...

11 years, 3 months ago (2013-02-04 02:04:01 UTC) #4

brainman

11 years, 3 months ago (2013-02-04 02:05:27 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b60d047de994 ***

net: prevent races during windows lookup calls

This only affects code (with exception of lookupProtocol)
that is only executed on older versions of Windows.

R=rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/7293043

Expand All Messages | Collapse All Messages