code review 72920046: cmd/gc: fix spurious 'not enough arguments to return' error

cmd/gc: fix spurious 'not enough arguments to return' error

Fixes issue 6405

[atom, 2014-03-10 12:34:41]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-03-10 15:50:34]

Can you add a test for this, if there isn't one already?

[atom, 2014-03-10 17:29:32]

On 2014/03/10 15:50:34, iant wrote:
> Can you add a test for this, if there isn't one already?

I added the test case. Please take another look.

[rsc, 2014-03-13 02:40:30]

https://codereview.appspot.com/72920046/diff/60001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/72920046/diff/60001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2249: }
can you add

if(n != nil)
    n->diag = 1;

here?
or does that break something?

[atom, 2014-03-14 13:47:59]

https://codereview.appspot.com/72920046/diff/60001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/72920046/diff/60001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2249: }
On 2014/03/13 02:40:30, rsc wrote:
> can you add
> 
> if(n != nil)
>     n->diag = 1;
> 
> here?
> or does that break something?

Done.

[atom, 2014-03-14 13:52:21]

I also added curly braces to improve readability of if-statements.

[rsc, 2014-03-14 14:54:40]

LGTM without braces

https://codereview.appspot.com/72920046/diff/80001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/72920046/diff/80001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2245: if(call != N) {
i'm sorry but please take the new braces out. they are inconsistent with the
convention in the rest of the source code. readability is more about looking
like the surrounding code than about any absolute good. it's okay that the c
code here looks different from go code.

[atom, 2014-03-14 15:42:10]

https://codereview.appspot.com/72920046/diff/80001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/72920046/diff/80001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2245: if(call != N) {
On 2014/03/14 14:54:40, rsc wrote:
> i'm sorry but please take the new braces out. they are inconsistent with the
> convention in the rest of the source code. readability is more about looking
> like the surrounding code than about any absolute good. it's okay that the c
> code here looks different from go code.

Done.

[atom, 2014-03-14 15:42:52]

*** Submitted as https://code.google.com/p/go/source/detail?r=3ac01afbcafc ***

cmd/gc: fix spurious 'not enough arguments to return' error

Fixes issue 6405

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/72920046