code review 7288053: cmd/go, testing: revise docs for test flags

cmd/go, testing: revise docs for test flags

In cmd/go's 'go help testflag':
* Rewrite list of flags to drop test. prefix on every name.
* Sort list of flags.
* Add example of using -bench to match all benchmarks.

In testing:
* Remove mention of undefined 'CPU group' concept.

Fixes issue 4488.
Fixes issue 4508.

[rsc, 2013-02-04 04:01:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[adg, 2013-02-04 04:08:30]

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go
File src/cmd/go/test.go (right):

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode96
src/cmd/go/test.go:96: Run enough iterations of each benchmark to take t.
what are the units for t?

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode136
src/cmd/go/test.go:136: -run pattern
for this and -bench you call this "pattern" but refer to them as "the regular
expression". should it be "-run expression" ?

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode154
src/cmd/go/test.go:154: after building it with 'go test -c'. When invoking the
test binary
s/$/,/

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode155
src/cmd/go/test.go:155: directory, each of the standard flag names must be
prefixed with 'test.',
s/directory, //

[rsc, 2013-02-04 04:15:07]

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go
File src/cmd/go/test.go (right):

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode96
src/cmd/go/test.go:96: Run enough iterations of each benchmark to take t.
It's a duration. Fixed.

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode136
src/cmd/go/test.go:136: -run pattern
On 2013/02/04 04:08:30, adg wrote:
> for this and -bench you call this "pattern" but refer to them as "the regular
> expression". should it be "-run expression" ?

When I wrote the text originally, I was trying to use a general term (pattern)
and then define what kind of pattern it is (regular expression). It's clearly
confused people. Changed to regexp. 'expression' is too vague.

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode154
src/cmd/go/test.go:154: after building it with 'go test -c'. When invoking the
test binary
On 2013/02/04 04:08:30, adg wrote:
> s/$/,/

not done, but only because the fix on the next line is s/directory/directly/

https://codereview.appspot.com/7288053/diff/4001/src/cmd/go/test.go#newcode155
src/cmd/go/test.go:155: directory, each of the standard flag names must be
prefixed with 'test.',
On 2013/02/04 04:08:30, adg wrote:
> s/directory, //

see previous line

[rsc, 2013-02-04 04:15:48]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2013-02-04 04:27:35]

LGTM

[rsc, 2013-02-04 04:47:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=0582ed1add0a ***

cmd/go, testing: revise docs for test flags

In cmd/go's 'go help testflag':
* Rewrite list of flags to drop test. prefix on every name.
* Sort list of flags.
* Add example of using -bench to match all benchmarks.

In testing:
* Remove mention of undefined 'CPU group' concept.

Fixes issue 4488.
Fixes issue 4508.

R=adg
CC=golang-dev
https://codereview.appspot.com/7288053