Issue 7288050: code review 7288050: syscall: NetBSD/ARM support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7288050: code review 7288050: syscall: NetBSD/ARM support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by minux1

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc, dave_cheney.net

Visibility:
Public.

Description

syscall: NetBSD/ARM support

Patch Set 1 #

Patch Set 2 : diff -r 437d7aefea45 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 437d7aefea45 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ada7873ff329 https://code.google.com/p/go/ #

Patch Set 5 : diff -r c224c490576b https://code.google.com/p/go/ #

Patch Set 6 : diff -r b489ac3f2e3e https://code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -17 lines)			Patch
M	src/pkg/syscall/asm_netbsd_arm.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/syscall_netbsd_arm.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_netbsd_arm.go	View	1 2 3 4	4 chunks	+4 lines, -15 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_netbsd_arm.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsysnum_netbsd_arm.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/pkg/syscall/ztypes_netbsd_arm.go	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2013-02-03 17:04:27 UTC) #1

minux1

ztypes_netbsd_arm.go has two type changes, should i manually revert them to keep the syscall package ...

12 years, 9 months ago (2013-02-03 17:06:25 UTC) #2

minux1

12 years, 8 months ago (2013-02-12 17:03:38 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=47bf18ec92f3 ***

syscall: NetBSD/ARM support

R=golang-dev, rsc, dave
CC=golang-dev
https://codereview.appspot.com/7288050

Expand All Messages | Collapse All Messages