Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(314)

Issue 7288045: code review 7288045: cmd/gc: allow new conversion syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by rsc
Modified:
12 years, 2 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: allow new conversion syntax For consistency with conversions that look like function calls, conversions that don't look like function calls now allow an optional trailing comma. That is, int(x,) has always been syntactically valid. Now []int(x,) is valid too. Fixes issue 4162.

Patch Set 1 #

Patch Set 2 : diff -r cf8e097deec5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cf8e097deec5 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -648 lines) Patch
M src/cmd/gc/go.y View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/y.tab.c View 1 12 chunks +653 lines, -643 lines 0 comments Download
M src/cmd/gc/yerr.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A test/fixedbugs/issue4162.go View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 2 months ago (2013-02-03 05:03:08 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c2dea601bb74 *** cmd/gc: allow new conversion syntax For consistency with conversions that ...
12 years, 2 months ago (2013-02-03 05:03:15 UTC) #2
ken3
12 years, 2 months ago (2013-02-03 05:42:23 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b