Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 7286043: code review 7286043: ssh/terminal: add darwin support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by agl1
Modified:
8 years, 10 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

ssh/terminal: add darwin support. terminal contains a number of utility functions that are currently only implemented for Linux. Darwin uses different named constants for getting and setting the terminal state so this change splits them off as constants and defines them for each arch.

Patch Set 1 #

Patch Set 2 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto/ #

Patch Set 9 : diff -r 7eef55bbd51c https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M ssh/terminal/util.go View 1 2 3 4 5 6 7 chunks +9 lines, -9 lines 0 comments Download
A ssh/terminal/util_bsd.go View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download
A ssh/terminal/util_linux.go View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
8 years, 10 months ago (2013-02-02 19:48:24 UTC) #1
minux1
On Sunday, February 3, 2013, agl wrote: > > Description: > ssh/terminal: add darwin support. ...
8 years, 10 months ago (2013-02-02 20:09:05 UTC) #2
agl1
On Sat, Feb 2, 2013 at 3:09 PM, minux <minux.ma@gmail.com> wrote: > use TIOCGETA for ...
8 years, 10 months ago (2013-02-02 20:23:09 UTC) #3
minux1
code LGTM. i suggest rename util_darwin.go to util_bsd.go, as i think the all *BSD use ...
8 years, 10 months ago (2013-02-02 20:34:42 UTC) #4
agl1
On Sat, Feb 2, 2013 at 3:34 PM, <minux.ma@gmail.com> wrote: > i suggest rename util_darwin.go ...
8 years, 10 months ago (2013-02-02 22:28:45 UTC) #5
minux1
On Sun, Feb 3, 2013 at 6:28 AM, Adam Langley <agl@golang.org> wrote: > On Sat, ...
8 years, 10 months ago (2013-02-02 22:31:57 UTC) #6
agl1
8 years, 10 months ago (2013-02-04 15:36:23 UTC) #7
*** Submitted as
https://code.google.com/p/go/source/detail?r=75e869cbf335&repo=crypto ***

ssh/terminal: add darwin support.

terminal contains a number of utility functions that are currently only
implemented for Linux. Darwin uses different named constants for
getting and setting the terminal state so this change splits them off
as constants and defines them for each arch.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7286043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b