Issue 72840043: code review 72840043: runtime: fix flakiness on futexsleep test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72840043: code review 72840043: runtime: fix flakiness on futexsleep test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by mikio

Modified:
11 years, 3 months ago

Reviewers:
gobot, jsing

CC:
golang-codereviews, jsing

Visibility:
Public.

Description

runtime: fix flakiness on futexsleep test Fixes issue 7496.

Patch Set 1 : diff -r fb17c23eee74 https://code.google.com/p/go #

Total comments: 3

Patch Set 2 : diff -r 1849f83423ca https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/pkg/runtime/futex_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-08 08:50:27 UTC) #1

jsing

LGTM https://codereview.appspot.com/72840043/diff/60001/src/pkg/runtime/futex_test.go File src/pkg/runtime/futex_test.go (right): https://codereview.appspot.com/72840043/diff/60001/src/pkg/runtime/futex_test.go#newcode38 src/pkg/runtime/futex_test.go:38: if runtime.GOMAXPROCS(0) > 1 { Obviously this does ...

11 years, 3 months ago (2014-03-10 02:24:47 UTC) #2

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=b2015fbc8fd3 *** runtime: fix flakiness on futexsleep test Fixes issue 7496. LGTM=jsing ...

11 years, 3 months ago (2014-03-10 03:20:22 UTC) #3

mikio

On Mon, Mar 10, 2014 at 11:24 AM, <jsing@google.com> wrote: > src/pkg/runtime/futex_test.go:38: if runtime.GOMAXPROCS(0) > ...

11 years, 3 months ago (2014-03-10 03:24:08 UTC) #4

gobot

11 years, 3 months ago (2014-03-10 03:25:22 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the darwin-386-cheney builder.

Expand All Messages | Collapse All Messages