Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 7278048: code review 7278048: cmd/gc: treat &T{} like new(T): allocate on stack if po... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rsc
Modified:
12 years, 5 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: treat &T{} like new(T): allocate on stack if possible Fixes issue 4618.

Patch Set 1 #

Patch Set 2 : diff -r 0b71a9db4cf6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0b71a9db4cf6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M src/cmd/gc/sinit.c View 1 2 chunks +9 lines, -2 lines 0 comments Download
A test/fixedbugs/issue4618.go View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 5 months ago (2013-02-03 04:54:19 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=cf8e097deec5 *** cmd/gc: treat &T{} like new(T): allocate on stack if possible ...
12 years, 5 months ago (2013-02-03 04:54:26 UTC) #2
ken3
12 years, 5 months ago (2013-02-03 09:15:15 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b