code review 7277050: time: fix error message from Parse

time: fix error message from Parse

Was incorrectly discarding the offending text in some cases.

Fixes issue 4493.

[rsc, 2013-02-04 04:58:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-02-04 04:59:57]

LGTM

On Sun, Feb 3, 2013 at 8:58 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> time: fix error message from Parse
>
> Was incorrectly discarding the offending text in some cases.
>
> Fixes issue 4493.
>
> Please review this at
https://codereview.appspot.**com/7277050/<https://codereview.appspot.com/7277...
>
> Affected files:
>   M src/pkg/time/format.go
>   M src/pkg/time/time_test.go
>
>
> Index: src/pkg/time/format.go
> ==============================**==============================**=======
> --- a/src/pkg/time/format.go
> +++ b/src/pkg/time/format.go
> @@ -611,14 +611,14 @@
>         for len(prefix) > 0 {
>                 if prefix[0] == ' ' {
>                         if len(value) > 0 && value[0] != ' ' {
> -                               return "", errBad
> +                               return value, errBad
>                         }
>                         prefix = cutspace(prefix)
>                         value = cutspace(value)
>                         continue
>                 }
>                 if len(value) == 0 || value[0] != prefix[0] {
> -                       return "", errBad
> +                       return value, errBad
>                 }
>                 prefix = prefix[1:]
>                 value = value[1:]
> Index: src/pkg/time/time_test.go
> ==============================**==============================**=======
> --- a/src/pkg/time/time_test.go
> +++ b/src/pkg/time/time_test.go
> @@ -676,6 +676,11 @@
>         // issue 4502. StampNano requires exactly 9 digits of precision.
>         {StampNano, "Dec  7 11:22:01.000000", `cannot parse ".000000" as
> ".000000000"`},
>         {StampNano, "Dec  7 11:22:01.0000000000", "extra text: 0"},
> +       // issue 4493. Helpful errors.
> +       {RFC3339, "2006-01-02T15:04:05Z07:00", `parsing time
> "2006-01-02T15:04:05Z07:00": extra text: 07:00`},
> +       {RFC3339, "2006-01-02T15:04_abc", `parsing time
> "2006-01-02T15:04_abc" as "2006-01-02T15:04:05Z07:00": cannot parse "_abc"
> as ":"`},
> +       {RFC3339, "2006-01-02T15:04:05_abc", `parsing time
> "2006-01-02T15:04:05_abc" as "2006-01-02T15:04:05Z07:00": cannot parse
> "_abc" as "Z07:00"`},
> +       {RFC3339, "2006-01-02T15:04:05Z_abc", `parsing time
> "2006-01-02T15:04:05Z_abc": extra text: _abc`},
>  }
>
>  func TestParseErrors(t *testing.T) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-02-04 05:00:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=0e8dbc496bd8 ***

time: fix error message from Parse

Was incorrectly discarding the offending text in some cases.

Fixes issue 4493.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7277050