Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(741)

Issue 7275048: code review 7275048: runtime/race: do not include pthread.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dvyukov
Modified:
11 years, 1 month ago
Reviewers:
CC:
brainman, minux1, golang-dev
Visibility:
Public.

Description

runtime/race: do not include pthread.h Fixes issue 4721.

Patch Set 1 #

Patch Set 2 : diff -r e2f9b9a58240 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e2f9b9a58240 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r fceaf0ddea29 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M src/pkg/runtime/race/testdata/cgo_test_main.go View 1 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 1 month ago (2013-02-04 08:20:38 UTC) #1
minux1
LGTM. Tested on windows/amd64 (windows 2008 r2). Passed 237 of 247 tests (95.95%, 0+, 10-) ...
11 years, 1 month ago (2013-02-04 12:43:54 UTC) #2
brainman
Still fails (in a different way) for me: === RUN TestNoRaceCgoSync ==4704== ERROR: Failed to ...
11 years, 1 month ago (2013-02-05 00:30:18 UTC) #3
dvyukov
On Tue, Feb 5, 2013 at 4:30 AM, <alex.brainman@gmail.com> wrote: > Still fails (in a ...
11 years, 1 month ago (2013-02-05 05:38:57 UTC) #4
brainman
On 2013/02/05 05:38:57, dvyukov wrote: > ... > Try to increase page file size. The ...
11 years, 1 month ago (2013-02-05 05:45:32 UTC) #5
brainman
LGTM Thank you. Alex
11 years, 1 month ago (2013-02-05 08:58:43 UTC) #6
dvyukov
11 years, 1 month ago (2013-02-05 09:08:20 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=d39dac749a8f ***

runtime/race: do not include pthread.h
Fixes issue 4721.

R=alex.brainman, minux.ma
CC=golang-dev
https://codereview.appspot.com/7275048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b