Issue 72750043: code review 72750043: cmd/gc: make the fpu handle all exceptions on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72750043: code review 72750043: cmd/gc: make the fpu handle all exceptions on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by ality

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
rsc, 0intro, golang-codereviews

Visibility:
Public.

Description

cmd/gc: make the fpu handle all exceptions on Plan 9 The compilers expect to not be interrupted by floating point exceptions. On Plan 9, every process starts with interrupts enabled for invalid operation, stack overflow, and divide by zero exceptions.

Patch Set 1 #

Patch Set 2 : diff -r fb17c23eee74 https://code.google.com/p/go #

Patch Set 3 : diff -r fb17c23eee74 https://code.google.com/p/go #

Patch Set 4 : diff -r 35d1f708a0d2 https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/cmd/gc/lex.c	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org, 0intro@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-08 10:41:41 UTC) #1

ality

11 years, 3 months ago (2014-03-13 02:41:59 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=322ffc6878d5 ***

cmd/gc: make the fpu handle all exceptions on Plan 9

The compilers expect to not be interrupted by floating
point exceptions. On Plan 9, every process starts with
interrupts enabled for invalid operation, stack overflow,
and divide by zero exceptions.

LGTM=rsc
R=rsc, 0intro
CC=golang-codereviews
https://codereview.appspot.com/72750043

Expand All Messages | Collapse All Messages