code review 7273046: net: use windows sysSocket everywhere

net: use windows sysSocket everywhere

[brainman, 2013-02-04 04:53:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-02-04 04:57:59]

LGTM

On Sun, Feb 3, 2013 at 8:53 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: use windows sysSocket everywhere
>
> Please review this at
https://codereview.appspot.**com/7273046/<https://codereview.appspot.com/7273...
>
> Affected files:
>   M src/pkg/net/fd_windows.go
>   M src/pkg/net/interface_windows.**go
>
>
> Index: src/pkg/net/fd_windows.go
> ==============================**==============================**=======
> --- a/src/pkg/net/fd_windows.go
> +++ b/src/pkg/net/fd_windows.go
> @@ -619,15 +619,10 @@
>         defer fd.decref()
>
>         // Get new socket.
> -       // See ../syscall/exec_unix.go for description of ForkLock.
> -       syscall.ForkLock.RLock()
> -       s, err := syscall.Socket(fd.family, fd.sotype, 0)
> +       s, err := sysSocket(fd.family, fd.sotype, 0)
>         if err != nil {
> -               syscall.ForkLock.RUnlock()
>                 return nil, &OpError{"socket", fd.net, fd.laddr, err}
>         }
> -       syscall.CloseOnExec(s)
> -       syscall.ForkLock.RUnlock()
>
>         // Associate our new socket with IOCP.
>         onceStartServer.Do(**startServer)
> Index: src/pkg/net/interface_windows.**go
> ==============================**==============================**=======
> --- a/src/pkg/net/interface_**windows.go
> +++ b/src/pkg/net/interface_**windows.go
> @@ -38,7 +38,7 @@
>  }
>
>  func getInterfaceList() ([]syscall.InterfaceInfo, error) {
> -       s, err := syscall.Socket(syscall.AF_**INET, syscall.SOCK_DGRAM,
> syscall.IPPROTO_UDP)
> +       s, err := sysSocket(syscall.AF_INET, syscall.SOCK_DGRAM,
> syscall.IPPROTO_UDP)
>         if err != nil {
>                 return nil, os.NewSyscallError("Socket", err)
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dave_cheney.net, 2013-02-04 05:00:07]

LGTM. Nice

On Mon, Feb 4, 2013 at 3:57 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
>
> On Sun, Feb 3, 2013 at 8:53 PM, <alex.brainman@gmail.com> wrote:
>>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> net: use windows sysSocket everywhere
>>
>> Please review this at https://codereview.appspot.com/7273046/
>>
>> Affected files:
>>   M src/pkg/net/fd_windows.go
>>   M src/pkg/net/interface_windows.go
>>
>>
>> Index: src/pkg/net/fd_windows.go
>> ===================================================================
>> --- a/src/pkg/net/fd_windows.go
>> +++ b/src/pkg/net/fd_windows.go
>> @@ -619,15 +619,10 @@
>>         defer fd.decref()
>>
>>         // Get new socket.
>> -       // See ../syscall/exec_unix.go for description of ForkLock.
>> -       syscall.ForkLock.RLock()
>> -       s, err := syscall.Socket(fd.family, fd.sotype, 0)
>> +       s, err := sysSocket(fd.family, fd.sotype, 0)
>>         if err != nil {
>> -               syscall.ForkLock.RUnlock()
>>                 return nil, &OpError{"socket", fd.net, fd.laddr, err}
>>         }
>> -       syscall.CloseOnExec(s)
>> -       syscall.ForkLock.RUnlock()
>>
>>         // Associate our new socket with IOCP.
>>         onceStartServer.Do(startServer)
>> Index: src/pkg/net/interface_windows.go
>> ===================================================================
>> --- a/src/pkg/net/interface_windows.go
>> +++ b/src/pkg/net/interface_windows.go
>> @@ -38,7 +38,7 @@
>>  }
>>
>>  func getInterfaceList() ([]syscall.InterfaceInfo, error) {
>> -       s, err := syscall.Socket(syscall.AF_INET, syscall.SOCK_DGRAM,
>> syscall.IPPROTO_UDP)
>> +       s, err := sysSocket(syscall.AF_INET, syscall.SOCK_DGRAM,
>> syscall.IPPROTO_UDP)
>>         if err != nil {
>>                 return nil, os.NewSyscallError("Socket", err)
>>         }
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[brainman, 2013-02-04 05:03:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=37eb20122f4c ***

net: use windows sysSocket everywhere

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/7273046